Skip to content

Conversation

@TanmayRanaware
Copy link
Contributor

@TanmayRanaware TanmayRanaware commented Oct 1, 2025

fixes #32

  • Created BDD-style test suite following existing patterns
  • Tests cover plain objects, futures/promises, event listeners
  • Includes edge cases and complex scenarios
  • Validates sink configuration structure
  • Ensures proper attribute application and removal

silky-x0 and others added 7 commits October 1, 2025 01:24
- Created BDD-style test suite following existing patterns
- Tests cover plain objects, futures/promises, event listeners
- Includes edge cases and complex scenarios
- Validates sink configuration structure
- Ensures proper attribute application and removal
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

@dariomannu dariomannu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good so far, just left a couple of notes, if you could please review them...

TanmayRanaware added 7 commits October 2, 2025 23:02
- Restructure test organization to use nested describe blocks
- Group tests by 'When' scenarios under each 'Given' context
- Improve maintainability and extensibility of test structure
- Make test scenarios more descriptive and organized
This file was added by other contributors (3mindedscholar, Pradeep Kaswan)
in commits f248b5a and 178c043, but should not be in this branch
which is focused on mixin sink unit tests.
- Restructure test organization to use nested describe blocks
- Add specific 'when' scenarios under each 'Given' context
- Improve maintainability and extensibility of test structure
- Make test scenarios more descriptive and organized
- Follow best practices for test organization as project grows
- Remove 'To Busy to read?, Check [TL;DR 📜](./QUICKSTART.md)' line
- Clean up README structure and flow
- Remove reference to QUICKSTART.md file
This file exists in master but was accidentally removed from this branch.
Restoring it to maintain consistency with master branch.
@dariomannu dariomannu merged commit f416fe9 into ReactiveHTML:master Oct 3, 2025
@dariomannu
Copy link
Contributor

@TanmayRanaware:

8 tests failed:
✗ Mixin Sink > Given a plain object mixin > when applying attributes to element > when boolean attributes are provided > handles boolean attributes correctly [3.00ms]
✗ Mixin Sink > Given a plain object mixin > when applying attributes to element > when falsey values are provided > removes attributes when set to falsey values [2.00ms]
✗ Mixin Sink > Given a future/promise mixin > when applying future attributes > when promise resolves successfully > applies future attributes when promise resolves [18.00ms]
✗ Mixin Sink > Given event listener mixins > when handling future event listeners > when promise resolves with event handlers > handles future event listeners [14.00ms]
✗ Mixin Sink > Given complex mixin scenarios > when handling mixed attribute types in single mixin > when all attribute types are combined > handles mixed attribute types in single mixin [2.00ms]
✗ Mixin Sink > Given edge cases > when an empty mixin object is given > when no attributes are provided > handles empty mixin object
✗ Mixin Sink > Given edge cases > when null or undefined values are given > when attributes have null/undefined values > handles null and undefined values in mixin
✗ Mixin Sink > Given edge cases > when string "false" values are given > when attributes contain string "false" > handles string "false" values correctly [1.00ms]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit test for the "Mixin" Sink

3 participants