-
-
Notifications
You must be signed in to change notification settings - Fork 32
Added comprehensive unit test suite for Mixin sink #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added comprehensive unit test suite for Mixin sink #39
Conversation
Added Unit Test for swap-source.ts
- Created BDD-style test suite following existing patterns - Tests cover plain objects, futures/promises, event listeners - Includes edge cases and complex scenarios - Validates sink configuration structure - Ensures proper attribute application and removal
|
|
dariomannu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good so far, just left a couple of notes, if you could please review them...
- Restructure test organization to use nested describe blocks - Group tests by 'When' scenarios under each 'Given' context - Improve maintainability and extensibility of test structure - Make test scenarios more descriptive and organized
- Restructure test organization to use nested describe blocks - Add specific 'when' scenarios under each 'Given' context - Improve maintainability and extensibility of test structure - Make test scenarios more descriptive and organized - Follow best practices for test organization as project grows
- Remove 'To Busy to read?, Check [TL;DR 📜](./QUICKSTART.md)' line - Clean up README structure and flow - Remove reference to QUICKSTART.md file
This file exists in master but was accidentally removed from this branch. Restoring it to maintain consistency with master branch.
|
8 tests failed: |
fixes #32