rxKotlin for rxJava2 #87

stepango · 2017-01-07T17:15:42Z

Start working on rxKotlin for rxJava2. For now, it's just a raw port of rxKotlin. Any feedback highly appreciated.

thomasnield · 2017-01-07T17:22:04Z

Awesome! I'll take a look later...

stepango · 2017-01-07T17:24:29Z

stepango · 2017-01-07T17:26:20Z

LICENSE

      To apply the Apache License to your work, attach the following
      boilerplate notice, with the fields enclosed by brackets "[]"
-      replaced with your own identifying information. (Don't include
+      replaced with your own identifying information. (Don'value include


Keep Don't

stepango · 2017-01-07T17:27:52Z

build.gradle


 task wrapper(type: Wrapper) {
-    gradleVersion = '2.2.1'
+    gradleVersion = '2.10'


Any chance for nebula to work with gradle 3+?

In RxAndroid we dropped nebula. It hurts more than it helps.

stepango · 2017-01-07T17:29:43Z

src/test/kotlin/rx/lang/kotlin/BasicKotlinTests.kt

-            subscriber.onNext("Hello")
-            subscriber.onCompleted()
-        }).subscribe { result ->
+        Observable.create<kotlin.String> { onSubscribe ->


kotlin.String -> String

JakeWharton · 2017-01-07T17:54:25Z

build.gradle


 task wrapper(type: Wrapper) {
-    gradleVersion = '2.2.1'
+    gradleVersion = '2.10'


In RxAndroid we dropped nebula. It hurts more than it helps.

JakeWharton · 2017-01-07T17:55:55Z

src/examples/kotlin/rx/lang/kotlin/examples/examples.kt

        println("--- Error ---\n${e.message}")
    }
-
+    


What's with all the added trailing whitespace?

Looks like default kotlin formatting settings in one of the last plugin releases.

JakeWharton · 2017-01-07T18:00:16Z

src/examples/kotlin/rx/lang/kotlin/examples/examples.kt

+fun asyncWiki(vararg articleNames: String): Observable<String> = observable { subscriber ->
+    thread {
+        articleNames.toObservable()
+                .flatMapMaybe { name: String -> URL("http://en.wikipedia.org/wiki/$name").toScannerObservable().firstElement() }


Does the argument need an explicit type?

JakeWharton · 2017-01-07T18:02:19Z

src/main/kotlin/rx/lang/kotlin/observables.kt

+/**
+ * [Observable.defer] alias
+ */
+fun <T : Any> Observable<T>.defer() = Observable.defer { this }


This shouldn't exist. The whole point of defer is the function is deferred to create an Observable. If you already have one there's no point in calling defer.

Agreed, forgot to delete it before commit

JakeWharton · 2017-01-07T18:03:41Z

src/main/kotlin/rx/lang/kotlin/observables.kt


-@Suppress("BASE_WITH_NULLABLE_UPPER_BOUND") fun <T> Observable<T>.onErrorReturnNull() : Observable<T?> = onErrorReturn<T> {null}
+fun <T : Any> T.toSingletonObservable(): Observable<T> = Observable.just(this)
+fun <T : Any> Throwable.toObservable(): Observable<T> = Observable.error(this)


These two are a bit ridiculous

Code review related fixes.

stepango · 2017-01-08T10:46:57Z

src/main/kotlin/rx/lang/kotlin/subscribers.kt

+import io.reactivex.disposables.Disposable
+import java.util.ArrayList
+
+class FunctionSubscriber<T : Any> : Observer<T>, MaybeObserver<T>, SingleObserver<T>, CompletableObserver {


Reimplement using OnSubscribe* interfaces

stepango · 2017-01-10T09:48:29Z

src/examples/kotlin/rx/lang/kotlin/examples/examples.kt

 }

-private fun URL.toScannerObservable() = observable<String> { s ->
+private fun URL.toScannerObservable() = observable<String>({ s ->


stepango · 2017-01-12T21:17:37Z

Porting subscribeWith was a good exercise but looks like i'll drop it from rxKotlin 2.x and rxKorlin 1.x as well. Probably release it as a separate artefact later.

thomasnield · 2017-01-12T23:44:27Z

I was thinking about that for a few days. Makes sense but it's too bad. Is there a way to present each action as a named parameter to subscribe()?

thomasnield · 2017-01-12T23:52:40Z

import io.reactivex.Observable

fun main(args: Array<String>) {

    Observable.just("Alpha", "Beta", "Gamma")
            .subscribe(onNext = ::println, onComplete = { println("done") })

}

fun <T> Observable<T>.subscribe(onNext: ((T) -> Unit)? = null,
                                onError: ((Throwable) -> Unit)? = null,
                                onComplete: (() -> Unit)? = null) = subscribe(onNext, onError, onComplete)

stepango · 2017-01-13T09:22:03Z

@thomasnield that's exactly what I'm thinking about. The only problem is - the name of a function, ide will not auto-import it because of the name clash. subscribeWith is taken already and has different semantics in rxJava2. As an option, function could be named subscribeBy. Any ideas?

stepango · 2017-01-13T15:44:57Z

RxJava2 don't accept null params in subscribe()

thomasnield · 2017-01-13T17:07:48Z

RxJava2 doesn't accept null anything it seems. I guess you can just create a hard observer in the implementation then...

flowable extensions added minor fixes

iNoles · 2017-02-11T22:14:16Z

@stepango According to https://kotlinlang.org/docs/reference/packages.html, you can use alias for name clash such as like "import bar.Bar as bBar // bBar stands for 'bar.Bar'"

stepango · 2017-02-12T08:53:28Z

@iNoles I know about import aliases, do you have some particular use case in mind?

iNoles · 2017-02-12T18:16:45Z

@stepango I was thinking about to use rxjava as import alias.

stepango · 2017-02-13T01:32:09Z

@iNoles don't get it. What exactly do you mean? Any code examples?

thomasnield · 2017-02-24T16:06:34Z

@stepango is it possible you can merge what you have into 2.x? I'd like to start contributing to this and it might be easier to centralize it into the repository.

stepango · 2017-02-25T06:05:51Z

@thomasnield was just about to do that. Finally, have some free time this weekend.

stepango added 2 commits September 6, 2016 09:29

Dependencies updated

1aa3555

Initial implementation of rxKotlin for rxJava2

3f2e99a

stepango mentioned this pull request Jan 7, 2017

RxJava 2.0 Planning? #80

Closed

stepango commented Jan 7, 2017

View reviewed changes

JakeWharton reviewed Jan 7, 2017

View reviewed changes

DavidMGross mentioned this pull request Jan 7, 2017

Document RxKotlin2 (RxKotlin version of RxJava 2.x) ReactiveX/reactivex.github.io#338

Closed

Code cleaning.

0f2ee08

Code review related fixes.

stepango self-assigned this Jan 8, 2017

Whitespaces removed.

54b37af

stepango commented Jan 8, 2017

View reviewed changes

gitignore update

ef24fa4

stepango commented Jan 10, 2017

View reviewed changes

stepango added 2 commits January 13, 2017 11:46

subscribers replaced by named args extension

2adeec2

subscribeBy non-null params

5478cec

empty* methods removed

06f3f03

flowable extensions added minor fixes

dependencies updated

8b1bbd6

stepango added 2 commits February 12, 2017 16:56

subscribeBy method for Flowable

02492c2

tests updated

484cbab

minor tests refactoring

e117048

stepango merged commit 2a6561c into ReactiveX:2.x Feb 25, 2017

rxKotlin for rxJava2 #87

rxKotlin for rxJava2 #87

Uh oh!

Conversation

stepango commented Jan 7, 2017

Uh oh!

thomasnield commented Jan 7, 2017

Uh oh!

stepango commented Jan 7, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stepango commented Jan 12, 2017

Uh oh!

thomasnield commented Jan 12, 2017

Uh oh!

thomasnield commented Jan 12, 2017

Uh oh!

stepango commented Jan 13, 2017

Uh oh!

stepango commented Jan 13, 2017

Uh oh!

thomasnield commented Jan 13, 2017

Uh oh!

iNoles commented Feb 11, 2017

Uh oh!

stepango commented Feb 12, 2017

Uh oh!

iNoles commented Feb 12, 2017

Uh oh!

stepango commented Feb 13, 2017

Uh oh!

thomasnield commented Feb 24, 2017

Uh oh!

stepango commented Feb 25, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants