Unsubscribe from auto release timeout if a subscriber comes along. #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the first item gets emitted very quickly, the timer will basically always be fired. If the timeout is very long, then all those subscriptions will land in the old generation and very expensive to pick up. This changeset unsubscribes immediately if a subscriber comes along, making it more likely that the subscription is still in the young gen and quicker to clean up.
Contributor
Author
|
@NiteshKant I made this change, because it has severe impact on GC behaviour (here tested with 70s delay). Of course it gets better in general if you reduce it to a few seconds only. Before:
After:
|
NiteshKant
added a commit
that referenced
this pull request
Feb 19, 2015
Unsubscribe from auto release timeout if a subscriber comes along.
Member
|
Thanks @daschl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first item gets emitted very quickly, the timer will basically
always be fired. If the timeout is very long, then all those subscriptions
will land in the old generation and very expensive to pick up.
This changeset unsubscribes immediately if a subscriber comes along, making
it more likely that the subscription is still in the young gen and quicker
to clean up.