UnicastContentSubject unsubscribes eagerly #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 18, 2015 15:55
`UnicastContentSubject` delegates buffering to a `BufferUntilSubscriber` subject. However, it subscribes the downstream subscriber to this subject using `Observable.unsubscribe()`. This causes a `SafeSubscriber` subscribing to the buffer subject which unsubscribes on termination of the upstream source.
The following code reproduces the issue:
```java
UnicastContentSubject<Long> subject = UnicastContentSubject.createWithoutNoSubscriptionTimeout();
subject.onNext(1l);
subject.onCompleted();
subject.flatMap(aLong -> Observable.never()
.doOnUnsubscribe(() -> System.out.println("unsubscribed")))
.toBlocking().toFuture().get();
```
In the above code the flatmap returns `Observable.never()` which should not get unsubscribed, unless the eventual subscriber unsubscribes.
Using `unsafeSubscribe()` to subscribe to the `BufferUntilSubscriber` will not eagerly unsubscribe.
Conflicts: rxnetty/src/main/java/io/reactivex/netty/protocol/http/UnicastContentSubject.java
Member
Author
|
This impacts cases when the lifetime of the child |
Contributor
|
LGTM. Get a release out for me :) |
NiteshKant
added a commit
that referenced
this pull request
Mar 18, 2015
UnicastContentSubject unsubscribes eagerly
|
I'm able to confirm that this fixed resolved the interrupted thread issue in my app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnicastContentSubjectdelegates buffering to aBufferUntilSubscribersubject. However, it subscribes the downstream subscriber to this subject usingObservable.unsubscribe(). This causes aSafeSubscribersubscribing to the buffer subject which unsubscribes on termination of the upstream source.The following code reproduces the issue:
In the above code the flatmap returns
Observable.never()which should not get unsubscribed, unless the eventual subscriber unsubscribes.Using
unsafeSubscribe()to subscribe to theBufferUntilSubscriberwill not eagerly unsubscribe.