Skip to content
This repository was archived by the owner on Oct 1, 2018. It is now read-only.

Conversation

@sumitarora
Copy link
Collaborator

Fixes: #64

@sumitarora
Copy link
Collaborator Author

@ashwin-sureshkumar @ladyleet If this is what's needed for docs for operator's I will start doing PR's for others too 😄

@codecov-io
Copy link

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   86.88%   86.88%           
=======================================
  Files           4        4           
  Lines          61       61           
  Branches        7        7           
=======================================
  Hits           53       53           
  Misses          5        5           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86bdde6...3a77c2d. Read the comment docs.

Copy link
Collaborator

@btroncone btroncone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@btroncone
Copy link
Collaborator

@ladyleet Any objections?

@ashwin-sureshkumar
Copy link
Collaborator

ashwin-sureshkumar commented Oct 27, 2017

@btroncone - In the existing docs there is a return type specified for operator which is missing in the OperatorDoc, is that by design or we need to add that section ?

@btroncone
Copy link
Collaborator

I don't think it's necessary, to me it's covered by the operator signature. eg public combineAll(project: function): Observable.

@sumitarora
Copy link
Collaborator Author

@btroncone @ashwin-sureshkumar One thing I noticed is the walkthrough.extras section is not getting rendered. Is someone working on that?

@btroncone
Copy link
Collaborator

@sumitarora Creating a PR for this right now.

@ladyleet
Copy link
Member

LGTM! Thx @sumitarora and thx @ashwin-sureshkumar for getting Sumit involved! :) Thx @btroncone for reviewing the PR.

@ladyleet ladyleet merged commit 29af945 into ReactiveX:master Oct 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants