fix(operators): added tips after operator description #137
Conversation
… use shared module
Added tips to display after operator long description if they exist. Also removed parameter section if no parameters exist.
| <app-operator-parameters | ||
| [operatorParameters]="parameters"> | ||
| [operatorParameters]="parameters" | ||
| *ngIf="paramaters?.length"> |
There was a problem hiding this comment.
Oops! Thanks for catching, sending up a fix now!
sumitarora
left a comment
sumitarora
left a comment
There was a problem hiding this comment.
Typo issue build is failing because of that not tests.
|
@sumitarora really appreciate you helping review PRs. |
|
Weird, looks like everything passed this time but something with selenium failed. Care to take a look @kwonoj? |
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 86.88% 88.46% +1.57%
==========================================
Files 4 7 +3
Lines 61 78 +17
Branches 7 7
==========================================
+ Hits 53 69 +16
- Misses 5 6 +1
Partials 3 3
Continue to review full report at Codecov.
|
|
It seems one time woes on travis. |
* refactor(Components): change to app.module and lazy loaded modules to use shared module * refactor(ToolbarComponent): to resolve layout issue with sidenav * refactor(sharedModule): removed duplicate import of sidemodule * fix(sidenav): resolved sidenav import issue
|
Can this be reviewed / merged? It fixes a couple of display issues on the operator page that may cause confusion to others checking their operator PR's. @ladyleet @kwonoj @sumitarora |
|
@btroncone Please rebase with master. |
Added tips to display after operator long description if they exist. Also removed parameter section if no parameters exist.
|
@btroncone 👍 - waiting on @kwonoj or @ashwin-sureshkumar to review & merge. |
7 participants
Added tips to display after operator long description if they exist. Also removed parameter section
if no parameters exist.