Skip to content
This repository was archived by the owner on Oct 1, 2018. It is now read-only.

Conversation

@knitcodemonkey
Copy link
Contributor

Add strong recommendation to use the commit script for creating commit messages

#19

…cript

Add strong recommendation to use the commit script for creating commit messages

ReactiveX#19
@knitcodemonkey
Copy link
Contributor Author

@kwonoj Here is the fix you requested for recommending users use the commit script for generating commit messages.

Copy link
Member

@kwonoj kwonoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@kwonoj
Copy link
Member

kwonoj commented Oct 18, 2017

Oh wait, I should be one 🚢 this one. 😅

@kwonoj
Copy link
Member

kwonoj commented Oct 18, 2017

and nit (not need to amend) but for shorthanded messages, commit can be docs(readme): .... instead of listing up all. No big deal now.

@rxjs-bot
Copy link

Warnings
⚠️

commit message does not follows conventional change log (1)

(1) : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check contributing guideline and update commit messages.

Generated by 🚫 dangerJS

@kwonoj kwonoj merged commit b6344d9 into ReactiveX:master Oct 18, 2017
@knitcodemonkey knitcodemonkey deleted the commitScriptDocumentation branch October 18, 2017 22:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants