Skip to content

test: empty Observable.toPromise#3623

Merged
benlesh merged 1 commit into
ReactiveX:masterfrom
NickLydon:empty-observable-topromise-test
May 3, 2018
Merged

test: empty Observable.toPromise#3623
benlesh merged 1 commit into
ReactiveX:masterfrom
NickLydon:empty-observable-topromise-test

Conversation

@NickLydon

Copy link
Copy Markdown
Contributor

Description:
show that an empty Observable results in a promise resolved with a
value of undefined

Related issue (if exists):

show that an empty Observable results in a promise resolved with a
value of undefined
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.2%) to 96.727% when pulling 8c51a76 on NickLydon:empty-observable-topromise-test into 8c5d680 on ReactiveX:master.

@benlesh benlesh merged commit e2f7e8a into ReactiveX:master May 3, 2018
@benlesh

benlesh commented May 3, 2018

Copy link
Copy Markdown
Member

Thank you for the thoughtful contribution, @NickLydon!

@lock

lock Bot commented Jun 5, 2018

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants