fix(pipe): align static pipe to Observable pipe rest parameters overl…#4112
Merged
benlesh merged 2 commits intoReactiveX:masterfrom Sep 25, 2018
Merged
fix(pipe): align static pipe to Observable pipe rest parameters overl…#4112benlesh merged 2 commits intoReactiveX:masterfrom
benlesh merged 2 commits intoReactiveX:masterfrom
Conversation
cartant
reviewed
Sep 8, 2018
Collaborator
cartant
left a comment
cartant
left a comment
There was a problem hiding this comment.
LGTM, but now that there is a rest parameters signature, could you include in the static pipe dtslint tests some tests like these two Observable.pipe tests?
Contributor
Author
|
OK. I will work on that. Thanks 😊 |
dkosasih
force-pushed
the
static_pipe_overload
branch
from
de36e97 to
9499645
Compare
Contributor
Author
|
@cartant I have added new commit for the tests. |
Contributor
Author
|
That was quick. Thanks 👍 |
|
pipeFromArray could also drop the type params now that no one calls it with anything other than <any, any> ? |
Collaborator
|
@jgbpercy Yes, |
benlesh
approved these changes
Sep 25, 2018
Member
|
currently, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Bring static pipe rest parameters overload to be in line with Observable.pipe
Related issue (if exists):
#4109