refactor(concat): support N-args with scheduler#5857
Merged
benlesh merged 6 commits intoReactiveX:masterfrom Oct 28, 2020
Merged
refactor(concat): support N-args with scheduler#5857benlesh merged 6 commits intoReactiveX:masterfrom
benlesh merged 6 commits intoReactiveX:masterfrom
Conversation
cartant
force-pushed
the
static-concat-n-args
branch
from
8d26c76 to
c8629d5
Compare
kolodny
reviewed
Oct 27, 2020
cartant
changed the title
benlesh
approved these changes
Oct 27, 2020
Doesn't matter here, but in situations with more overloads, the 'simple' signature has to come first.
Collaborator
Author
|
@benlesh FYI, I've pushed some post-approval commits to re-order the signatures so that the signature with the trailing scheduler comes last. Here, it doesn't matter, but if there are two or more trailing arguments, it matters a lot. I've re-ordered these to, hopefully, not give anyone else the wrong idea regarding the ordering of the sigs if this is used as the basis/example for other refactors, etc. |
benlesh
approved these changes
Oct 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR refactors the static
concatto use N-args in the signature that accepts a trailing scheduler. And adds a bunch of this-usage-should-fail dtslint tests.For whatever reason, the problems that occurred in the PRs that were opened for the static
mergeandcombineLastestfunctions do not seem to occur here. A lot was going on in those PRs - and the conversations that took place in those PRs aren't especially easy to follow - but I would not be surprised if there is some small difference that effects different behaviour. For example, temporarily adding a signature that included a concurrency (for the purposes of experimentation) seemed to break things, so ... 🤷♂️ this seems fine here, but we might still have problems elsewhere. 🤞Related issue (if exists): None