refactor(merge): support N-args with concurrency and scheduler#5877
Merged
benlesh merged 2 commits intoReactiveX:masterfrom Nov 17, 2020
Merged
refactor(merge): support N-args with concurrency and scheduler#5877benlesh merged 2 commits intoReactiveX:masterfrom
benlesh merged 2 commits intoReactiveX:masterfrom
Conversation
cartant
force-pushed
the
static-merge-n-args
branch
from
b7aaa0f to
52d5130
Compare
Using ObservableInputTuple, etc.
cartant
force-pushed
the
static-merge-n-args
branch
from
ccb6893 to
5c5da02
Compare
cartant
changed the title
benlesh
approved these changes
Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
#5844 was closed in favour of #5859, but that PR refactored only the operators - not the static
merge.This PR refactors the static
mergeto useObservableInputTuple, etc.FWIW, I'm aware that there is an
argsOrArgArraycall in the implementation, but IMO we should not be introducing signatures that allow arrays of sources to be passed tomerge. AFAICT, there were no such signatures prior to the refactor and there are no such signatures in version 6. Furthermore, there are behavioural differences betweenconcatandmergebecause of this. Basically, I've spent a chunk of time compiling a table of the signature and implementation differences (for v6 and v7) relating to arrays of sources and varargs. I'd like to keep this PR as simple as possible and address said differences in other PRs/issues. AFAICT, there are numerous inconsistencies.Related issue (if exists): None