feat: allow embedded ReadAlong in <read-along> element#203
Conversation
|
Nice and simple, and I like the resulting format, and I'm impressed at how easy it was to support. We will have to document somewhere that the Am I right in assuming that If there's no risk, then it doesn't matter and we can keep it this way, but in the documentation I would only mention the child node syntax unless and until there was a use case. |
Yes, I guess this should go in the web component documentation?
Yes, this makes sense, I've updated it to just do that! |
|
I've also updated the Studio-Web application to embed the ReadAlong in the downloaded stand-alone HTML, to facilitate manual editing. It's still encoded as base64 for the actual component in the Angular application, because just inserting it into the component is one of these seemly obvious things (like, I just want to add things to a DOM element!!!) that is impossibly difficult to figure out how to do in Angular. Maybe ChatGPT can do it for me. |
Small caveat, you *must* use the <text> element to enclose it even though this is optional for standalone ReadAlong files.
1b53dc0 to
44f6ce8
Compare
|
Hi - I modified this slightly so that it merely accepts the embedded ReadAlong in the web component, since there is maybe limited value in having the alignments expanded out in the all-in-one HTML download. I also bumped the minor version number of the web component as this is a significant new feature that other code may want to depend on. |
Small caveat, you must use the
<text>element to enclose it even though this is optional for standalone ReadAlong files.This was surprisingly easy, the only quirk is that it gets parsed as HTML rather than XML, so the
nodeNameproperty is uppercase for everything inside it.