feat: add aligner fallback settings for difficult alignments#207
Merged
feat: add aligner fallback settings for difficult alignments#207
Conversation
roedoejet
force-pushed
the
dev.aligner-fallback
branch
from
7fd2557 to
29e60aa
Compare
Collaborator
|
Oh, cool, thank you! I just haven't had the time to look into this. The implementation seems clear and simple, I'll review it a bit more closely soon. |
roedoejet
force-pushed
the
dev.aligner-fallback
branch
from
29e60aa to
35de363
Compare
roedoejet
force-pushed
the
dev.aligner-fallback
branch
from
35de363 to
04943a2
Compare
dhdaines
approved these changes
Jun 19, 2023
Collaborator
dhdaines
left a comment
dhdaines
left a comment
There was a problem hiding this comment.
Looks good! I guess this is what the retry operator is for :)
Member
|
Tested on my machine, finally. Nicely done, it works well. I would just change the setting back to strict each time the user clicks on "next step". |
Member
|
And it looks like you already did that, so good to merge. |
reset alignment mode to strict after alignment
roedoejet
force-pushed
the
dev.aligner-fallback
branch
from
40fcbe0 to
d3defb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a PR for implementing the same loosening of beam parameters as found in Studio cli. This is missing French and Spanish translations, and should be tested. I tested it locally with the Ende language files that were not working previously, but this ties in to the larger problems with testing for Studio-Web, and would also require test data that is open source (unlike the Ende example).