Skip to content

feat: simplify language selection#209

Merged
roedoejet merged 9 commits intomainfrom
dev.language
Jun 23, 2023
Merged

feat: simplify language selection#209
roedoejet merged 9 commits intomainfrom
dev.language

Conversation

@roedoejet
Copy link
Copy Markdown
Collaborator

No description provided.

@joanise
Copy link
Copy Markdown
Member

joanise commented Jun 21, 2023

The English looks great, thanks!
Question, is it normal that when some strings are missing, trying to serve the Spanish or French interface just fails to compile? I get these error messages, which are really not saying to me "translate some missing strings"!

./packages/ngx-web-component/src/lib/ngx-web-component.module.ts:5:0-20 - Error: export 'defineCustomElements' (imported as 'defineCustomElements') was not found in '@readalongs/web-component/loader' (module has no exports)

./packages/studio-web/src/app/app.module.ts:19:0-20 - Error: export 'defineCustomElements' (imported as 'defineCustomElements') was not found in '@readalongs/web-component/loader' (module has no exports)

@joanise
Copy link
Copy Markdown
Member

joanise commented Jun 21, 2023

Bug: the Tour is broken in Step 2. Once I get to the second "Play your readalong" shepherd step, it just gives me a greyed out screen without the next step or any way to continue. I have to reload the whole page to recover.

@roedoejet
Copy link
Copy Markdown
Collaborator Author

The English looks great, thanks! Question, is it normal that when some strings are missing, trying to serve the Spanish or French interface just fails to compile? I get these error messages, which are really not saying to me "translate some missing strings"!

./packages/ngx-web-component/src/lib/ngx-web-component.module.ts:5:0-20 - Error: export 'defineCustomElements' (imported as 'defineCustomElements') was not found in '@readalongs/web-component/loader' (module has no exports)

./packages/studio-web/src/app/app.module.ts:19:0-20 - Error: export 'defineCustomElements' (imported as 'defineCustomElements') was not found in '@readalongs/web-component/loader' (module has no exports)

No, I don't get that at all - this sounds like a problem with nx/the web component not being installed properly. I get these messages:

./packages/studio-web/src/app/shepherd.steps.ts - Warning: Module Warning (from ./node_modules/@angular-devkit/build-angular/src/babel/webpack-loader.js):
(Emitted value instead of an instance of Error) No translation found for "5598621379448184205" ("For most users, the default settings here are appropriate, and you don't need to do anything else - just keep this option selected!").

./packages/studio-web/src/app/shepherd.steps.ts - Warning: Module Warning (from ./node_modules/@angular-devkit/build-angular/src/babel/webpack-loader.js):
(Emitted value instead of an instance of Error) No translation found for "6215852496756629103" ("Then, optionally, you can select the language of your ReadAlong.").

./packages/studio-web/src/app/upload/upload.component.ts - Warning: Module Warning (from ./node_modules/@angular-devkit/build-angular/src/babel/webpack-loader.js):
(Emitted value instead of an instance of Error) No translation found for "3896053555277429649" ("Please select a language or choose the default option").

./packages/studio-web/src/app/upload/upload.component.ts - Warning: Module Warning (from ./node_modules/@angular-devkit/build-angular/src/babel/webpack-loader.js):
(Emitted value instead of an instance of Error) No translation found for "4382352341548079905" ("Select a specific language").

./packages/studio-web/src/app/upload/upload.component.ts - Warning: Module Warning (from ./node_modules/@angular-devkit/build-angular/src/babel/webpack-loader.js):
(Emitted value instead of an instance of Error) No translation found for "7273199130532280751" (" Optional: Change language settings ").

@roedoejet
Copy link
Copy Markdown
Collaborator Author

Bug: the Tour is broken in Step 2. Once I get to the second "Play your readalong" shepherd step, it just gives me a greyed out screen without the next step or any way to continue. I have to reload the whole page to recover.

Weird. I'll look into this

@roedoejet
Copy link
Copy Markdown
Collaborator Author

@joanise - I think I fixed the tour issue here: 00e026e but I have no idea why it came up in this PR - it should have been an issue before too, but it appears to work on the site

@joanise
Copy link
Copy Markdown
Member

joanise commented Jun 21, 2023

@joanise - I think I fixed the tour issue here: 00e026e but I have no idea why it came up in this PR - it should have been an issue before too, but it appears to work on the site

All I can say is that it works in origin/main but not in this branch. When I played with it, I did not understand why and why not, so I figured I'd just leave a note here. Glad you figured it out!

@joanise
Copy link
Copy Markdown
Member

joanise commented Jun 21, 2023

The first "Edit your ReadAlong" shepherd step is no longer attached to Title/Subtitle the way it used to be, did some element change name or id?

@roedoejet
Copy link
Copy Markdown
Collaborator Author

The first "Edit your ReadAlong" shepherd step is no longer attached to Title/Subtitle the way it used to be, did some element change name or id?

It should be as of 00e026e - have you tried it since then?

@joanise
Copy link
Copy Markdown
Member

joanise commented Jun 22, 2023

The first "Edit your ReadAlong" shepherd step is no longer attached to Title/Subtitle the way it used to be, did some element change name or id?

It should be as of 00e026e - have you tried it since then?

I thought I had, but I must have been on the wrong branch when I tested, it works fine now.

@joanise
Copy link
Copy Markdown
Member

joanise commented Jun 22, 2023

Currently working on the French translation for this PR.

@joanise
Copy link
Copy Markdown
Member

joanise commented Jun 22, 2023

The contact us link embedded in the tour is also broken. It ends up trying to open http://localhost:4200/%7B%7B%20contactLink%20%7D%7D instead of the intended mailto: target.
I can fix it by hard-coding <a href="mailto:readalong.studio@gmail.com"> in shepherd.steps.ts but it would of course be nicer to maintain the parameterization we had with the e-mail address coming ultimately from package.json as it does elsewhere.

joanise added 3 commits June 22, 2023 11:57
I can no longer serve the es and fr pages on these ports, but 4203 and
4204 work so I'm just going to apply this stupid hack so I can keep on
working.
@joanise
Copy link
Copy Markdown
Member

joanise commented Jun 22, 2023

I've now made some fixes on the English, a hack so I could spin up the es and fr interface on my machine again, and a complete draft of the French translations.
TODO:

  • Spanish translations
  • fix the contact link in the tour

@joanise
Copy link
Copy Markdown
Member

joanise commented Jun 22, 2023

And, a complete first draft of the Spanish translations is now in too.
@roedoejet can you check the contactLink in the shepherd tour, and ask for a review of the Spanish text?
@dhdaines I think you were willing to review my French text, that would be helpful please.

@joanise
Copy link
Copy Markdown
Member

joanise commented Jun 23, 2023

Doh, I fixed the messages for the fixed tour yesterday, but forgot to push. This PR now just needs native speaker review and can get merged.

@roedoejet roedoejet merged commit 919a842 into main Jun 23, 2023
@roedoejet roedoejet deleted the dev.language branch June 23, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants