Skip to content

fix: show the toast for digit errors again #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joanise wants to merge 1 commit into from
Closed

fix: show the toast for digit errors again #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/studio-web/src/app/upload/upload.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ Please check it to make sure all words are spelled out completely, e.g. write "4
}
return throwError(() => err);
} else {
return of(err);
return throwError(() => err);
Copy link
Copy Markdown
Collaborator

@roedoejet roedoejet Jun 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. but doesn't this cause retry to trigger? I'll test this.

Copy link
Copy Markdown
Collaborator

@roedoejet roedoejet Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, on my machine this triggers the error message three times since any error thrown will cause retry to trigger:

image

}
}),
retry(2),
Expand Down