Conversation
|
|
Nice, thanks for tackling this! On Studio-Web, things are better, though not perfect yet. Studio-Web screen shots: This one is great, with the whole tall image visible: This one is even taller, 1100 pixels tall, and still gets cropped a bit at the bottom (you should completely see my two hand-drawn corners at the bottom): Web-Component screen shots: On the downloaded Web-C, the original problem persists: |
| @extend %themed-bg; | ||
| img { | ||
| height: 100%; | ||
| max-height: $page-size + 0vh; |
There was a problem hiding this comment.
I hate CSS! A huge amount of work, for a one-line change in the end!
|
Same results on the iPad: in Studio-Web, I can now see my tall image. But in the downloaded html, viewed in Edge on the iPad, it's still blank. |
|
To make sure that wasn't the problem, I checked, and |
Hm. The only way to know for sure is to inspect the image in the browser to see if the new CSS is getting picked up. I was having a lot of problems getting nx to actually rebuild things, some bogus caching was getting in the way. |
|
I'm surprised you were having trouble. I now just run this command: and everything starts reliably for me. |
|
Right, yeah, in Studio-Web: In downloaded Web-C: |
|
OK, I can confirm it was because the bundle did not get updated: it contains the old code: |
|
And it's because we need to run and commit the results! Doh! |
|
Although the workflow that creates the PR Preview does run that command, and so do our publish and release workflows, so I don't quite understand why we have to do it by hand. |
|
Argh! I updated the bundle. It's now fixed locally. But not on the PR preview. Help! @roedoejet |
|
Got it! It's because we're fetching the bundle from the live version, not the PR preview: It's only a bug in the PR preview, then, which is fetching assets from |
2 participants
This seems to effectively fix the issues with displaying images on iPads, and also enforces what I think is a reasonable height on uploaded images, namely, 55vh, which is in theory also the same maximum height as a page (it seems to make them a bit smaller because nobody can comprehend where the size of an element actually comes from in CSS)