Skip to content

fix: use relative URLs for all assets#219

Merged
joanise merged 1 commit intomainfrom
dev.relative-assets
Jul 5, 2023
Merged

fix: use relative URLs for all assets#219
joanise merged 1 commit intomainfrom
dev.relative-assets

Conversation

@joanise
Copy link
Copy Markdown
Member

@joanise joanise commented Jul 5, 2023

Fixes #218

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 5, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://ReadAlongs.github.io/Web-Component/pr-preview/pr-219/
on branch gh-pages at 2023-07-05 14:39 UTC

@joanise joanise requested a review from roedoejet July 5, 2023 14:45
Copy link
Copy Markdown
Collaborator

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joanise - this seems like the right thing to do

Base automatically changed from dev.image-height to main July 5, 2023 20:32
@joanise joanise merged commit fa3f005 into main Jul 5, 2023
@joanise joanise deleted the dev.relative-assets branch July 5, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assets are loaded from /assets even when deploying to a subfolder

2 participants