Three small changes: play/pause tooltip, mat icon typo, aria recommendation#220
Merged
Three small changes: play/pause tooltip, mat icon typo, aria recommendation#220
Conversation
Using error_outline_outlined worked anyway, but the extra _outlined was basically ignored and cause extra spaces to get inserted.
Member
Author
|
Note: I'm not sure my Spanish translation is OK, with "Déle play/pause", but I was adapting from the existing text. I'm hoping for a native speaker review before merging. |
Contributor
|
dhdaines
approved these changes
Jul 6, 2023
Collaborator
dhdaines
left a comment
dhdaines
left a comment
There was a problem hiding this comment.
I will defer to a native speaker for the Spanish translation (which I find a bit shocking! where's the equivalent of the OQLF?) but aside from that this seems quite sensible.
with native speaker review on Reproducir/pausar and make the tooltips that are next to each other consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.