fix: refactoring translations to rely on readalong DOM instead of state#330
fix: refactoring translations to rely on readalong DOM instead of state#330
Conversation
|
deltork
force-pushed
the
dev.del/328-translation-tier-issue
branch
from
45c8e32 to
ad9ef75
Compare
Fixed, pushed a work-around for version <1.1 with translation tiers without id |
deltork
force-pushed
the
dev.del/328-translation-tier-issue
branch
2 times, most recently
from
94f0875 to
d52b764
Compare
deltork
force-pushed
the
dev.del/328-translation-tier-issue
branch
from
d52b764 to
9225d2b
Compare
|
@joanise I need translation help |
joanise
left a comment
joanise
left a comment
There was a problem hiding this comment.
Question: OK with changing "annotation title" to "annotation layer" in the menu/widget to edit the layers?
| "edit-layer": "Rename annotation title", | ||
| "delete-layer": "Remove annotation title", | ||
| "save-layer": "Save annotation title", | ||
| "create-layer": "Create an annotation title" |
There was a problem hiding this comment.
These are not intuitive to me. I would change all of them to "annotation layer" instead of "annotation title".
| "edit-layer": "Renommer le titre de l'annotation", | ||
| "delete-layer": "Supprimer le titre de l'annotation", | ||
| "save-layer": "Enregistrer le titre de l'annotation", | ||
| "create-layer": "Créer un titre d'annotation" |
There was a problem hiding this comment.
And here "la/une couche d'annotation" instead of "le titre".
This is consistent with the translations I did for the tour.
| "edit-layer": "Cambiar el nombre del título de la anotación", | ||
| "delete-layer": "Eliminar el título de la anotación", | ||
| "save-layer": "Guardar el título de la anotación", | ||
| "create-layer": "Crear un título de anotación" |
There was a problem hiding this comment.
And "la/una capa de anotación".
joanise
left a comment
joanise
left a comment
There was a problem hiding this comment.
This is now ready to merge as far as I'm concerned.
*fix: refactoring translations to rely on readalong DOM instead of state (#330) * fix: refactoring translations to rely on readalong DOM instead of state * test: fix test for editing readalong * feat: es and fr translations for layers messages * fix: refine some translations and text strings --------- Co-authored-by: Eric Joanis <eric.joanis@nrc-cnrc.gc.ca>
3 participants
PR Goal?
Rewrite of the translation tier to accomodate the creation of annotation layers
Fixes?
#328
Feedback sought?
sanity check
Priority?
high
Tests added?
How to test?
test with the following files
ej-fra.readalong,ej-fra-annotated.readalong,ej-fra-translated.readalongfound in packages/web-component/test-data/ej-fraConfidence?
high
Version change?
minor
TODO: