CI: matrix testing: test with Node 14 and Node 16#53
Merged
Conversation
Ref: https://sass-lang.com/d/slash-div Fixes this warning that we get when we run `npm start` and in CI: DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0. Recommendation: math.div($target, $context) More info and automated migrator: https://sass-lang.com/d/slash-div ╷ 35 │ @return $target / $context + 0em; │ ^^^^^^^^^^^^^^^^^^ ╵ src/scss/utilities/_functions.scss 35:13 em() src/scss/utilities/_extends.scss 14:20 @import src/scss/utilities/_index.scss 17:9 @import stdin 35:9 root stylesheet
One rogue instance was killed about 6h on Node 18 by GitHub Actions itself, but that's a lot of wasted resources!
The cypress-io test runs using Node 18 get stuck after launching the app on localhost:3333 and never seem to get to proceed to actually running the test suite. The logs like quite different with Node 14 or 16, where things work fine. See for example: https://github.com/ReadAlongs/Web-Component/actions/runs/3569070697 or https://github.com/ReadAlongs/Web-Component/actions/runs/3440162866 So I'm going to separate matrix testing from making things work with Node 18.
joanise
force-pushed
the
dev.matrix-testing
branch
from
1e7e030 to
819d6bc
Compare
roedoejet
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
end-to-end-tests.yml doesn't pass with Node 18 at the moment, but it does with Node 14 and Node 16, two currently supported LTS versions, so we should test on those systematically in CI.