Merged
Conversation
CodeQL is pretty expensive. Let's stop running it on every push to every PR. One per PR merge is plenty, and on cron is still useful in case vulnerabilities appear in dependencies or existing vulnerabilities are newly discovered.
Co-authored-by: Delasie Torkornoo <delasie.torkornoo@carleton.ca>
Member
Author
|
@roedoejet This is ready to review and merge. |
Member
Author
|
The unit tests fail because an actual test case fails, but they do actually run. |
roedoejet
approved these changes
Jan 31, 2023
| } | ||
| }, | ||
| "defaultBase": "master", | ||
| "defaultBase": "main", |
Collaborator
There was a problem hiding this comment.
Was this actually necessary in the end?
Member
Author
There was a problem hiding this comment.
Wow, I have no recollection of this change. I don't know.
| @@ -0,0 +1,21 @@ | |||
| export interface Page { | |||
Collaborator
There was a problem hiding this comment.
Why are these moved to this location?
Member
Author
There was a problem hiding this comment.
This is some refactoring Del was doing. I don't know all the details. It makes more sense with the rest of the page_transition PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't have CI working yet, but these changes are good, I'd like to merge them into
dev.monorepo, so that the images and state-fix branches can be rebased onto this work.