docs: clarify how to run the component and the app locally#69
Merged
Conversation
roedoejet
requested changes
Feb 2, 2023
|
|
||
| #### Understanding where the components come from when you run locally | ||
|
|
||
| When you run `nx serve Studio-Web`, that process is actually serving all the components needed |
Collaborator
There was a problem hiding this comment.
not exactly true - it's not serving them, it's just that nx build web-component puts the built components in the place that nx imports them (via the paths defined in the root tsconfig.base.json). I think "serve" is misleading because it makes it seem like we're putting them on a port somewhere or something.
Member
Author
There was a problem hiding this comment.
Subtle, but OK. I've made a patch, let me know if it is better now.
Member
Author
|
@roedoejet I'll squash merge this PR if you are happy with it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.