Create modules

[PuneetGopinath]

Checks

I have...

• read and understood the Contributing Guidelines
• Updated any nessecary files such as the README.md and/or CHANGELOG.md.

Type of Pull request

• Minor Change
  This Pull request doesn't break existing configuration.
• Major Change
  This Pull request will break existing configuration.
• Bug fix
  This Pull request will fix a (critical) bug.
• Documentation
  This Pull request only changes documentation (README.md, CHANGELOG.md, etc.)
• Other: Split the index.js file into different modules

Description

Split the index.js file into:

recent-activity/
└── index.js
└── config.js
└── functions/
    └── appendDate.js
    └── commitFile.js
    └── execute.js
    └── filterContent.js
    └── makeCustomUrl.js
    └── toUrlFormat.js
└── serializers.js

Closes #

[PuneetGopinath]

@Andre601 Looks like the pr template has a closing bracket ()) in the end of the file.

[Andre601]

@Andre601 Looks like the pr template has a closing bracket ()) in the end of the file.

Correct it :P

[PuneetGopinath]

@abhijoshi2k Sorry, I forgot to add ./ when importing module. Ok, can we set this pr to ready for review?

[abhijoshi2k]

@abhijoshi2k Sorry, I forgot to add ./ when importing module. Ok, can we set this pr to ready for review?

Not yet. There are issues with build workflow

[PuneetGopinath]

But checks passed?

[PuneetGopinath]

But checks passed?

@abhijoshi2k

[abhijoshi2k]

But checks passed?

Yes but you can check logs. Some issue with if statement. I'm trying to resolve

[PuneetGopinath]

Yes, I saw those, but they didn't produce any error, so I left them.

[PuneetGopinath]

They already came, the first time I changes the if statement

[PuneetGopinath]

Anyway, I tested them right now in PuneetGopinath/activity-test

[abhijoshi2k]

Yes, I saw those, but they didn't produce any error, so I left them.

It's not working correctly even if there's no error

[PuneetGopinath]

Yes, I saw those, but they didn't produce any error, so I left them.

It's not working correctly even if there's no error

Ok, can you check them.

[abhijoshi2k]

Yes, I saw those, but they didn't produce any error, so I left them.

It's not working correctly even if there's no error

Ok, can you check them.

Yes

[PuneetGopinath]

How can we access node.js console in GitHub actions?

[PuneetGopinath]

Additionally would I suggest to keep Changelog and readme changes in their own PR. Mainly to avoid the release drafter messing up the categories, especially now after hiding any documentation changes to it.

That's what I also thought, only you everytime open a new pr to update the ChangeLog

[abhijoshi2k]

Workflow is fixed, right?

Not yet. Should we allow it to make empty commit?
It will resolve the issue

Should we do this?

[PuneetGopinath]

Workflow is fixed, right?

Not yet. Should we allow it to make empty commit?
It will resolve the issue

Should we do this?

I didn't understand what you meant by It will resolve the issue but I thought you meant I will resolve the issue, and so I gave a 👍 reaction

[abhijoshi2k]

I didn't understand what you meant by It will resolve the issue but I thought you meant I will resolve the issue, and so I gave a 👍 reaction

I meant that the action will make an empty commit when no changes are seen
So issue will be resolved. Should we do that?

[PuneetGopinath]

@Andre601 I replied to your requested changes.

[PuneetGopinath]

I didn't understand what you meant by It will resolve the issue but I thought you meant I will resolve the issue, and so I gave a 👍 reaction

I meant that the action will make an empty commit when no changes are seen
So issue will be resolved. Should we do that?

👍 Yes, do it is what I meant

[abhijoshi2k]

Okay I'll make the changes

[PuneetGopinath]

@abhijoshi2k Have you ever used EndBug/add-and-commit?

[abhijoshi2k]

@abhijoshi2k Have you ever used EndBug/add-and-commit?

No I was trying

[PuneetGopinath]

@abhijoshi2k Plz review

[abhijoshi2k]

@abhijoshi2k Plz review

Looks good. I'll test and approve

[abhijoshi2k]

Working Properly