update to iOS 9.2 SDK and define sysroot for iOS#480
Merged
Conversation
Previously, we only seemed to define sysroot for MacOS, not iOS, yet we reference $(sysroot) in both cases. This ensures it is defined in both cases as well.
|
|
||
| ios-version := $(shell \ | ||
| if test -L $(sdk-dir)/$(target)9.1.sdk; then echo 9.1; \ | ||
| if test -L $(sdk-dir)/$(target)9.2.sdk; then echo 9.2; \ |
Collaborator
There was a problem hiding this comment.
This is getting slightly out of hand. How about something like this:?
for x in 9.3 9.2 9.1; do if test -d $(sdk-dir)/$(target)$x.sdk -o -L $(sdk-dir)/$(target)$x.sdk; then echo $x; break; fi; done
Member
Author
There was a problem hiding this comment.
Good idea. I just pushed an update.
Collaborator
|
Looks like travis had a little hickup. Could you force-push a no-op change to re-trigger the build? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we only seemed to define sysroot for MacOS, not iOS, yet
we reference $(sysroot) in both cases. This ensures it is defined in
both cases as well.