Populate participants/challenges#412
Merged
swarajpure merged 11 commits intoRealDevSquad:developfrom Sep 16, 2021
Merged
Conversation
swarajpure
suggested changes
Aug 2, 2021
Contributor
swarajpure
left a comment
swarajpure
left a comment
There was a problem hiding this comment.
Needs discussion on this one.
I'm not able to understand what you're trying to achieve and the way you're doing it, seems too inefficient
swarajpure
suggested changes
Aug 3, 2021
swarajpure
suggested changes
Sep 1, 2021
Contributor
swarajpure
left a comment
swarajpure
left a comment
There was a problem hiding this comment.
Requesting some changes for readability reasons
swarajpure
reviewed
Sep 4, 2021
swarajpure
reviewed
Sep 4, 2021
swarajpure
reviewed
Sep 15, 2021
swarajpure
reviewed
Sep 15, 2021
swarajpure
reviewed
Sep 15, 2021
swarajpure
reviewed
Sep 16, 2021
swarajpure
reviewed
Sep 16, 2021
prakashchoudhary07
added a commit
that referenced
this pull request
Nov 1, 2021
* api to make new members members * changes suggested * 400 on user already a member and api schema generation script run * review changes * added test cases * review changes * moved nonSuperUser to top * Bump color-string from 1.5.3 to 1.5.5 Bumps [color-string](https://github.com/Qix-/color-string) from 1.5.3 to 1.5.5. - [Release notes](https://github.com/Qix-/color-string/releases) - [Changelog](https://github.com/Qix-/color-string/blob/master/CHANGELOG.md) - [Commits](https://github.com/Qix-/color-string/commits/1.5.5) --- updated-dependencies: - dependency-name: color-string dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Removed generateUrl method * Define CRUD operation for feature flag * Added integration and unit tests for the feature flag * Generated api schema for feature flags * Added small changes in routes/featureFlags.js * added .js extensions * Update package-lock.json * Added wiki link to the backend setup video * Added user badges api with a simple test * Handled edge cases, enhanced the code, and wrote new tests * Fixed all the validators to strictly follow the schema as it is by default converting the string to number * Made the code clean * Made the code cleaner * change self task api ready (#408) * api schema ready * checking for conflicts * minor line changes * api ready * unnecessary files deleted * percentCompleted field can also be changed now * status and percentCompleted made optional in validators * response code changes to 200 * using strint for validators * Increased the readability of code * resolved merge conflicts * Feature/node v14 check (#419) * Added a check for node -v14 * update * test for Patch /tasks/self/:id (#416) * test for Patch /tasks/self/:id * removing unnecessary logic * storing user to db and using cleanDB * using user from fixtures * removing comments * added test for no cookie * Populate participants/challenges (#412) * will not work if participants array elem > 10 * overcoming in query limitation * storing id insted of name * using fetchUser from users.model for fetching user * a little bit refactoring of code * post-challenges/subscribe response updated * made requested changes * using 204 for response * refactoring response code * getting promise array from a function * refactoring get method in controllers/challenges * Bump axios from 0.21.1 to 0.21.2 Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md) - [Commits](axios/axios@v0.21.1...v0.21.2) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * use user who is not a member * Add Api schema * Update constants/roles.js following snakecase Co-authored-by: Sumit Dhanania <sumitdhanania94@gmail.com> * Update controllers/members.js Co-authored-by: Sumit Dhanania <sumitdhanania94@gmail.com> * update role * update member test * challenges API refactored (#271) * [WIP] challenges API refactored * refactored challenges get and post * validators for createChallenge * using timestamps for date * seperating get and post routes * boom response changes Co-authored-by: akshay shinde <akshayshinde7289@gmail.com> * Bump passport-oauth2 from 1.5.0 to 1.6.1 Bumps [passport-oauth2](https://github.com/jaredhanson/passport-oauth2) from 1.5.0 to 1.6.1. - [Release notes](https://github.com/jaredhanson/passport-oauth2/releases) - [Changelog](https://github.com/jaredhanson/passport-oauth2/blob/master/CHANGELOG.md) - [Commits](jaredhanson/passport-oauth2@v1.5.0...v1.6.1) --- updated-dependencies: - dependency-name: passport-oauth2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Added optional chaining and updated test * Increased profile upload limit to 5MB * Update storage to 2 mb * Sync main with develop (#411) (#434) * Removed generateUrl method * Define CRUD operation for feature flag * Added integration and unit tests for the feature flag * Generated api schema for feature flags * Added small changes in routes/featureFlags.js * added .js extensions * Update package-lock.json * Added wiki link to the backend setup video * Fixed all the validators to strictly follow the schema as it is by default converting the string to number * change self task api ready (#408) * api schema ready * checking for conflicts * minor line changes * api ready * unnecessary files deleted * percentCompleted field can also be changed now * status and percentCompleted made optional in validators * response code changes to 200 * using strint for validators Co-authored-by: Prakash <om.pcprakash@gmail.com> Co-authored-by: Ankita Bannore <bannoreankita20@gmail.com> Co-authored-by: tapansawant <tapansawant45@gmail.com> Co-authored-by: Pranav Gajjewar <apbetahouse45@gmail.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: lakshayman <lakshaymanchanda73@gmail.com> Co-authored-by: Akshay Shinde <55057874+akshay1502@users.noreply.github.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Swaraj Rajpure <56217868+swarajpure@users.noreply.github.com> Co-authored-by: Ankur Narkhede <ankurnarkhede@gmail.com> Co-authored-by: Sumit Dhanania <sumitdhanania94@gmail.com> Co-authored-by: Ankita Bannore <bannoreankita20@gmail.com> Co-authored-by: tapansawant <tapansawant45@gmail.com> Co-authored-by: Pranav Gajjewar <apbetahouse45@gmail.com> Co-authored-by: lakshayman <lakshaymanchanda73@gmail.com> Co-authored-by: Akshay Shinde <55057874+akshay1502@users.noreply.github.com> * Bugfix/develop merge issues (#439) * Sync main with develop (#411) * Removed generateUrl method * Define CRUD operation for feature flag * Added integration and unit tests for the feature flag * Generated api schema for feature flags * Added small changes in routes/featureFlags.js * added .js extensions * Update package-lock.json * Added wiki link to the backend setup video * Fixed all the validators to strictly follow the schema as it is by default converting the string to number * change self task api ready (#408) * api schema ready * checking for conflicts * minor line changes * api ready * unnecessary files deleted * percentCompleted field can also be changed now * status and percentCompleted made optional in validators * response code changes to 200 * using strint for validators Co-authored-by: Prakash <om.pcprakash@gmail.com> Co-authored-by: Ankita Bannore <bannoreankita20@gmail.com> Co-authored-by: tapansawant <tapansawant45@gmail.com> Co-authored-by: Pranav Gajjewar <apbetahouse45@gmail.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: lakshayman <lakshaymanchanda73@gmail.com> Co-authored-by: Akshay Shinde <55057874+akshay1502@users.noreply.github.com> * chore: fix package-lock and apiSchema.json (#435) * Revert "chore: fix package-lock and apiSchema.json (#435)" (#436) This reverts commit 02416de. Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Swaraj Rajpure <56217868+swarajpure@users.noreply.github.com> Co-authored-by: Ankur Narkhede <ankurnarkhede@gmail.com> Co-authored-by: Sumit Dhanania <sumitdhanania94@gmail.com> Co-authored-by: Ankita Bannore <bannoreankita20@gmail.com> Co-authored-by: tapansawant <tapansawant45@gmail.com> Co-authored-by: Pranav Gajjewar <apbetahouse45@gmail.com> Co-authored-by: lakshayman <lakshaymanchanda73@gmail.com> Co-authored-by: Akshay Shinde <55057874+akshay1502@users.noreply.github.com> * Bugfix/develop merge issues (#439) * Sync main with develop (#411) * Removed generateUrl method * Define CRUD operation for feature flag * Added integration and unit tests for the feature flag * Generated api schema for feature flags * Added small changes in routes/featureFlags.js * added .js extensions * Update package-lock.json * Added wiki link to the backend setup video * Fixed all the validators to strictly follow the schema as it is by default converting the string to number * change self task api ready (#408) * api schema ready * checking for conflicts * minor line changes * api ready * unnecessary files deleted * percentCompleted field can also be changed now * status and percentCompleted made optional in validators * response code changes to 200 * using strint for validators Co-authored-by: Prakash <om.pcprakash@gmail.com> Co-authored-by: Ankita Bannore <bannoreankita20@gmail.com> Co-authored-by: tapansawant <tapansawant45@gmail.com> Co-authored-by: Pranav Gajjewar <apbetahouse45@gmail.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: lakshayman <lakshaymanchanda73@gmail.com> Co-authored-by: Akshay Shinde <55057874+akshay1502@users.noreply.github.com> * chore: fix package-lock and apiSchema.json (#435) * Revert "chore: fix package-lock and apiSchema.json (#435)" (#436) This reverts commit 02416de. Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Swaraj Rajpure <56217868+swarajpure@users.noreply.github.com> Co-authored-by: Ankur Narkhede <ankurnarkhede@gmail.com> Co-authored-by: Sumit Dhanania <sumitdhanania94@gmail.com> Co-authored-by: Ankita Bannore <bannoreankita20@gmail.com> Co-authored-by: tapansawant <tapansawant45@gmail.com> Co-authored-by: Pranav Gajjewar <apbetahouse45@gmail.com> Co-authored-by: lakshayman <lakshaymanchanda73@gmail.com> Co-authored-by: Akshay Shinde <55057874+akshay1502@users.noreply.github.com> Co-authored-by: Nandita Kalita <nanditakalita@MacBook-Pro.local> Co-authored-by: nandita1 <nandita.kalita1@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Prakash <om.pcprakash@gmail.com> Co-authored-by: Ankita Bannore <bannoreankita20@gmail.com> Co-authored-by: tapansawant <tapansawant45@gmail.com> Co-authored-by: Pranav Gajjewar <apbetahouse45@gmail.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Vividh Bhardwaj <bhardwajvividh@gmail.com> Co-authored-by: Vividh Bhardwaj <61474917+Vividh25@users.noreply.github.com> Co-authored-by: lakshayman <lakshaymanchanda73@gmail.com> Co-authored-by: Akshay Shinde <55057874+akshay1502@users.noreply.github.com> Co-authored-by: Sumit Dhanania <sumitdhanania94@gmail.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com> Co-authored-by: Swebert Correa <correaswebert@gmail.com> Co-authored-by: akshay shinde <akshayshinde7289@gmail.com> Co-authored-by: Ankur Narkhede <ankurnarkhede@gmail.com> Co-authored-by: ankushdharkar <ankushdharkar@gmail.com>
swarajpure
added a commit
that referenced
this pull request
Nov 30, 2021
* api to make new members members * changes suggested * 400 on user already a member and api schema generation script run * review changes * added test cases * review changes * moved nonSuperUser to top * Bump color-string from 1.5.3 to 1.5.5 Bumps [color-string](https://github.com/Qix-/color-string) from 1.5.3 to 1.5.5. - [Release notes](https://github.com/Qix-/color-string/releases) - [Changelog](https://github.com/Qix-/color-string/blob/master/CHANGELOG.md) - [Commits](https://github.com/Qix-/color-string/commits/1.5.5) --- updated-dependencies: - dependency-name: color-string dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Removed generateUrl method * Define CRUD operation for feature flag * Added integration and unit tests for the feature flag * Generated api schema for feature flags * Added small changes in routes/featureFlags.js * added .js extensions * Update package-lock.json * Added wiki link to the backend setup video * Added user badges api with a simple test * Handled edge cases, enhanced the code, and wrote new tests * Fixed all the validators to strictly follow the schema as it is by default converting the string to number * Made the code clean * Made the code cleaner * change self task api ready (#408) * api schema ready * checking for conflicts * minor line changes * api ready * unnecessary files deleted * percentCompleted field can also be changed now * status and percentCompleted made optional in validators * response code changes to 200 * using strint for validators * Increased the readability of code * resolved merge conflicts * Feature/node v14 check (#419) * Added a check for node -v14 * update * test for Patch /tasks/self/:id (#416) * test for Patch /tasks/self/:id * removing unnecessary logic * storing user to db and using cleanDB * using user from fixtures * removing comments * added test for no cookie * Populate participants/challenges (#412) * will not work if participants array elem > 10 * overcoming in query limitation * storing id insted of name * using fetchUser from users.model for fetching user * a little bit refactoring of code * post-challenges/subscribe response updated * made requested changes * using 204 for response * refactoring response code * getting promise array from a function * refactoring get method in controllers/challenges * Bump axios from 0.21.1 to 0.21.2 Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md) - [Commits](axios/axios@v0.21.1...v0.21.2) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * use user who is not a member * Add Api schema * Update constants/roles.js following snakecase Co-authored-by: Sumit Dhanania <sumitdhanania94@gmail.com> * Update controllers/members.js Co-authored-by: Sumit Dhanania <sumitdhanania94@gmail.com> * update role * update member test * challenges API refactored (#271) * [WIP] challenges API refactored * refactored challenges get and post * validators for createChallenge * using timestamps for date * seperating get and post routes * boom response changes Co-authored-by: akshay shinde <akshayshinde7289@gmail.com> * Bump passport-oauth2 from 1.5.0 to 1.6.1 Bumps [passport-oauth2](https://github.com/jaredhanson/passport-oauth2) from 1.5.0 to 1.6.1. - [Release notes](https://github.com/jaredhanson/passport-oauth2/releases) - [Changelog](https://github.com/jaredhanson/passport-oauth2/blob/master/CHANGELOG.md) - [Commits](jaredhanson/passport-oauth2@v1.5.0...v1.6.1) --- updated-dependencies: - dependency-name: passport-oauth2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Added optional chaining and updated test * Increased profile upload limit to 5MB * Update storage to 2 mb * Sync main with develop (#411) (#434) * Removed generateUrl method * Define CRUD operation for feature flag * Added integration and unit tests for the feature flag * Generated api schema for feature flags * Added small changes in routes/featureFlags.js * added .js extensions * Update package-lock.json * Added wiki link to the backend setup video * Fixed all the validators to strictly follow the schema as it is by default converting the string to number * change self task api ready (#408) * api schema ready * checking for conflicts * minor line changes * api ready * unnecessary files deleted * percentCompleted field can also be changed now * status and percentCompleted made optional in validators * response code changes to 200 * using strint for validators Co-authored-by: Prakash <om.pcprakash@gmail.com> Co-authored-by: Ankita Bannore <bannoreankita20@gmail.com> Co-authored-by: tapansawant <tapansawant45@gmail.com> Co-authored-by: Pranav Gajjewar <apbetahouse45@gmail.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: lakshayman <lakshaymanchanda73@gmail.com> Co-authored-by: Akshay Shinde <55057874+akshay1502@users.noreply.github.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Swaraj Rajpure <56217868+swarajpure@users.noreply.github.com> Co-authored-by: Ankur Narkhede <ankurnarkhede@gmail.com> Co-authored-by: Sumit Dhanania <sumitdhanania94@gmail.com> Co-authored-by: Ankita Bannore <bannoreankita20@gmail.com> Co-authored-by: tapansawant <tapansawant45@gmail.com> Co-authored-by: Pranav Gajjewar <apbetahouse45@gmail.com> Co-authored-by: lakshayman <lakshaymanchanda73@gmail.com> Co-authored-by: Akshay Shinde <55057874+akshay1502@users.noreply.github.com> * chore: fix package-lock and apiSchema.json * Bugfix/develop merge issues (#439) * Sync main with develop (#411) * Removed generateUrl method * Define CRUD operation for feature flag * Added integration and unit tests for the feature flag * Generated api schema for feature flags * Added small changes in routes/featureFlags.js * added .js extensions * Update package-lock.json * Added wiki link to the backend setup video * Fixed all the validators to strictly follow the schema as it is by default converting the string to number * change self task api ready (#408) * api schema ready * checking for conflicts * minor line changes * api ready * unnecessary files deleted * percentCompleted field can also be changed now * status and percentCompleted made optional in validators * response code changes to 200 * using strint for validators Co-authored-by: Prakash <om.pcprakash@gmail.com> Co-authored-by: Ankita Bannore <bannoreankita20@gmail.com> Co-authored-by: tapansawant <tapansawant45@gmail.com> Co-authored-by: Pranav Gajjewar <apbetahouse45@gmail.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: lakshayman <lakshaymanchanda73@gmail.com> Co-authored-by: Akshay Shinde <55057874+akshay1502@users.noreply.github.com> * chore: fix package-lock and apiSchema.json (#435) * Revert "chore: fix package-lock and apiSchema.json (#435)" (#436) This reverts commit 02416de. Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Swaraj Rajpure <56217868+swarajpure@users.noreply.github.com> Co-authored-by: Ankur Narkhede <ankurnarkhede@gmail.com> Co-authored-by: Sumit Dhanania <sumitdhanania94@gmail.com> Co-authored-by: Ankita Bannore <bannoreankita20@gmail.com> Co-authored-by: tapansawant <tapansawant45@gmail.com> Co-authored-by: Pranav Gajjewar <apbetahouse45@gmail.com> Co-authored-by: lakshayman <lakshaymanchanda73@gmail.com> Co-authored-by: Akshay Shinde <55057874+akshay1502@users.noreply.github.com> * Bugfix/develop merge issues (#439) * Sync main with develop (#411) * Removed generateUrl method * Define CRUD operation for feature flag * Added integration and unit tests for the feature flag * Generated api schema for feature flags * Added small changes in routes/featureFlags.js * added .js extensions * Update package-lock.json * Added wiki link to the backend setup video * Fixed all the validators to strictly follow the schema as it is by default converting the string to number * change self task api ready (#408) * api schema ready * checking for conflicts * minor line changes * api ready * unnecessary files deleted * percentCompleted field can also be changed now * status and percentCompleted made optional in validators * response code changes to 200 * using strint for validators Co-authored-by: Prakash <om.pcprakash@gmail.com> Co-authored-by: Ankita Bannore <bannoreankita20@gmail.com> Co-authored-by: tapansawant <tapansawant45@gmail.com> Co-authored-by: Pranav Gajjewar <apbetahouse45@gmail.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: lakshayman <lakshaymanchanda73@gmail.com> Co-authored-by: Akshay Shinde <55057874+akshay1502@users.noreply.github.com> * chore: fix package-lock and apiSchema.json (#435) * Revert "chore: fix package-lock and apiSchema.json (#435)" (#436) This reverts commit 02416de. Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Swaraj Rajpure <56217868+swarajpure@users.noreply.github.com> Co-authored-by: Ankur Narkhede <ankurnarkhede@gmail.com> Co-authored-by: Sumit Dhanania <sumitdhanania94@gmail.com> Co-authored-by: Ankita Bannore <bannoreankita20@gmail.com> Co-authored-by: tapansawant <tapansawant45@gmail.com> Co-authored-by: Pranav Gajjewar <apbetahouse45@gmail.com> Co-authored-by: lakshayman <lakshaymanchanda73@gmail.com> Co-authored-by: Akshay Shinde <55057874+akshay1502@users.noreply.github.com> * feat: archive users/members from the members page (#427) * feat: archive members * generated api schema * added: check if user is already archived or not * bug fix * added: optional chaining * added: move to member model. * added: integration test for testing archive member feature * key changed to camelCase * Added: requested changes * added: requested changes * added: requested changes * bug fix * fix: typo * removed unwanted code. * removed unwanted code * Fixed schema * added: requested changes * added: requested changes Co-authored-by: Nandita Kalita <nanditakalita@MacBook-Pro.local> Co-authored-by: nandita1 <nandita.kalita1@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Prakash <om.pcprakash@gmail.com> Co-authored-by: Ankita Bannore <bannoreankita20@gmail.com> Co-authored-by: tapansawant <tapansawant45@gmail.com> Co-authored-by: Pranav Gajjewar <apbetahouse45@gmail.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Vividh Bhardwaj <bhardwajvividh@gmail.com> Co-authored-by: Vividh Bhardwaj <61474917+Vividh25@users.noreply.github.com> Co-authored-by: lakshayman <lakshaymanchanda73@gmail.com> Co-authored-by: Akshay Shinde <55057874+akshay1502@users.noreply.github.com> Co-authored-by: Sumit Dhanania <sumitdhanania94@gmail.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com> Co-authored-by: Swebert Correa <correaswebert@gmail.com> Co-authored-by: akshay shinde <akshayshinde7289@gmail.com> Co-authored-by: Ankur Narkhede <ankurnarkhede@gmail.com> Co-authored-by: ankushdharkar <ankushdharkar@gmail.com> Co-authored-by: Mehul Kiran Chaudhari <55375534+MehulKChaudhari@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if participants array contains more than 10 elements then code is using while loop to make a query with 10 elements of an array
and iterate over the array till the end.