test: buy + sell cubit subset, no PR-conflict overlap (+22 tests)#337
Merged
Conversation
Stage 13 of the coverage push. - sell_selected_bank_account_cubit (3): initial null, select emits the account, select(null) clears - sell_balance_cubit (4): initial zero balance derived from AppStore, subscribes to BalanceRepository.watchBalance on init, emits each pushed balance, close() cancels cleanly - sell_bank_accounts_cubit (6): Success with mapped DTOs on init, LoadFailure on getBankAccounts throw, add() calls createBankAccount + refetches, AddFailure preserves prior accounts, deactivate() calls updateBankAccount(isActive=false) + refetches, UpdateFailure preserves prior accounts - buy_converter_cubit (9): initial empty state, onFiatChanged debounces + writes converted shares, debounce keeps only the last value, error path leaves state stable, onSharesChanged matches output fractional digits to the input (and defaults to 2 without dot), onCurrencyChanged refetches in the new currency, currency still flips on service error, close() cancels pending debounce timers (no service call after close)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage 13 of the coverage push. Covers four cubits in the sell and buy flows whose source files are NOT touched by the currently-open #321 (dashboard buy actions, sell_page) or #332 (bitbox sign).
What each file covers
Excluded (and why)
Test plan