test(service): transaction_history_service.apiBasedSync (+8 tests)#342
Merged
Conversation
Stage 19 of the coverage push. Covers the previously-deferred apiBasedSync method (separate test file from fetchPendingTransactions to keep mocks focused). - non-200 on /history → no repository writes (early return) - entries with no transfer are skipped - inserts a plain Transaction when no matching DFX row exists - inserts a DFX-enriched transaction when /v1/transaction has a row with id matching inputTxId - existing transactions go through updateTransaction (not insert) - existing DFX rows go through updateDfxTransaction - outputTxId match also resolves the DFX record (not just inputTxId) - DFX rows without an id fall back to the plain-Transaction insert path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage 19 of the coverage push. Closes the previously-deferred apiBasedSync gap on TransactionHistoryService — kept in a separate file from `fetchPendingTransactions` (#336) to keep the repository mocks focused on the sync flow.
What it covers
Notes
Test plan