test(utils): svg_parser + device_info + default_assets (+14 tests)#345
Merged
Conversation
Stage 22 of the coverage push. Pure-Dart utility files. - svg_parser (5): integer + decimal mm → px conversion at 96 DPI, non-mm units passthrough, replaces every mm occurrence, preserves surrounding SVG markup - device_info (5): iOS / Android / macOS / Windows+Linux / Fuchsia platform-flag matrix (with debugDefaultTargetPlatformOverride save + restore around each test) - default_assets (4): mainnet + Sepolia contract / chainId / decimals pinned to the production values; ETH and ZCHF asset-id constants
PR #321 removed DfxWidgetService from HomeBloc but didn't update the test, leaving develop's home_bloc_test.dart broken — CI on every subsequent PR fails the compile step. This bundles the fix into the stage 23 PR so unblocking can happen in one merge instead of a separate fix PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage 22 of the coverage push. Pure-Dart utility files.
What each file covers
Test plan