test: NetworkMode + ApiConfig + mnemonic_field extension (+11 tests)#346
Merged
Conversation
…11 tests) Stage 23 of the coverage push. - network_mode (3): mainnet getters + name; testnet getters + name; enum has exactly 2 values (catches accidental additions that would silently bypass switch-on-mode call sites) - api_config (6 new alongside 2 existing): testnet asset = realUnitTestAsset; testnet ETH/ZCHF ids = Sepolia ids; mainnet asset = realUnitAsset; mainnet ETH/ZCHF ids = Ethereum ids; buildUri produces https URIs; appends/omits queryParams correctly - mnemonic_field SeedStringExtension (5): splits 12-word mnemonic; collapses tabs / multi-space; empty + whitespace-only → []; trims; preserves word order
PR #321 removed DfxWidgetService from HomeBloc but didn't update the test, leaving develop's home_bloc_test.dart broken — CI on every subsequent PR fails the compile step. This bundles the fix into the stage 23 PR so unblocking can happen in one merge instead of a separate fix PR.
TaprootFreak
added a commit
to joshuakrueger-dfx/realunit-app
that referenced
this pull request
May 15, 2026
… merge Two professional cleanup items found while reviewing the PR end-to-end: - `toBitboxSafeAsciiOrNull` was defined and tested but never called from production code — `git grep` shows 0 callsites outside its own spec. Removed the 2-line wrapper and its dedicated test group. If a nullable variant is ever needed, callers can use `?.let(toBitboxSafeAscii)` or the helper can be re-added when there is an actual consumer. - `test/screens/home/home_bloc_test.dart` survived the merge with `origin/develop` (commit ba1a968) carrying its pre-RealUnitCH#346 shape: it still referenced the removed `DfxWidgetService` and passed 7 positional args to a 6-arg `HomeBloc(...)`. CI did not flag it on this branch but any local `flutter analyze` reports 4 errors. Aligned the file with the develop tip so the type-mismatch is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage 23 of the coverage push. Three small pure-Dart targets that round out the config + widget-extension surface.
What each file covers
Test plan