test(models): Asset + Balance + Transaction (+14 tests)#350
Merged
Conversation
Stage 26 of the coverage push. Pure-Dart model classes. - Asset (5): id from fastHash(chainId:address); Asset.getId static matches the instance getter; different chains / addresses produce different ids; id depends only on chain+address, not on metadata (name/symbol/decimals don't affect identity) - Balance (5): id from fastHash(wallet:chain:contract); balance amount is mutable; two Balances with the same identity tuple are == regardless of amount (pinned so a stream-emitted update with a new amount can still match an existing map key); different chain / wallet differs - Transaction (3): isOutbound true when sender matches wallet (EIP-55 normalised); false when sender differs; normalises hex- digit case on both sides via fromHex/hexEip55 - TransactionTypes (1): values has exactly 5 entries (catches an accidental addition that would silently break the rendering switch)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage 26 of the coverage push. Pure-Dart model classes.
What each model pins
Test plan