test(dto): pdf + support + bank account + buy payment info (+21 tests)#362
Merged
Conversation
Stage 38 of the coverage push. Pure value-object + DTO file covering PDF wire surface, support issue ladder, BankAccount equatable contract and BuyPaymentInfo equality. - MultiReceiptDto.toJson (2): defaults CHF; renames txIds → txHashes - SingleReceiptDto.toJson (2): defaults CHF; renames txId → txHash - PdfDto.fromJson (1): reads pdfData - BalancePdfDto.toJson (2): default EN (uppercased on wire); override + uppercased language code - SupportIssueType (3): round-trip; falls back to genericIssue; toJson returns wire value - SupportIssueReason (2): round-trip; falls back to other - SupportIssueState (2): round-trip; falls back to created - SupportIssueDto.fromJson (2): full happy path; absent messages → [] - SupportIssue (2): isOpen for created/pending only; fromDto maps fields - BankAccount (2): equality by id only; isActive defaults to false - BuyPaymentInfo (1): equatable props pin every field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage 38 of the coverage push. Pure value-object + DTO file covering the PDF wire surface, the support issue ladder, BankAccount equatable contract and BuyPaymentInfo equality.
Cases
What's pinned
Test plan