fix(kyc): skip completed steps in pendingReview, remove canTrade#523
Merged
Merged
Conversation
…de field pendingReview picked the first isRequired step regardless of completion status, so it could select an already-completed step instead of the one actually under review. Now filters on isRequired && !completed. Also removes UserKycDto.canTrade (field, comment, constructor param, JSON deser) since the API no longer returns it.
TaprootFreak
added
the
tier3:full
This was referenced May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isRequiredstep, but could land on one that was alreadycompleted. Now filtersisRequired && status != completedso it always selects the step actually under review.UserKycDto.canTrade— field, comment, constructor param, and JSON deserialization — since the API no longer returns it.Test plan
kyc_cubit_testcases passcanTraderemain