docs(testing): correct disconnect exception in FakeBitboxBehavior table#565
Merged
TaprootFreak merged 1 commit intoMay 23, 2026
Conversation
The FakeBitboxBehavior table claimed `disconnect` throws SigningCancelledException, but the fake actually throws BitboxNotConnectedException (see test/helper/fake_bitbox_credentials.dart:89). Both are distinct exception classes: - SigningCancelledException — user-cancel path - BitboxNotConnectedException — disconnect / not-paired path The cancel-flow code example below the table is correct and stays unchanged.
TaprootFreak
changed the base branch from
develop
to
feat/visual-regression-pilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/testing.md:280claimedFakeBitboxBehavior.disconnectthrowsSigningCancelledException. The fake actually throwsBitboxNotConnectedExceptionattest/helper/fake_bitbox_credentials.dart:89.Both are distinct exception classes serving distinct intents:
SigningCancelledExceptionlib/packages/wallet/exceptions/signing_cancelled_exception.dartBitboxNotConnectedExceptionlib/packages/service/dfx/exceptions/bitbox_exception.dartThe cancel-flow code example immediately below the table (lines 284-295) is correct and stays unchanged — it tests the
cancelbehavior, which legitimately surfaces asSigningCancelledExceptionthroughEip712Signer.signRegistrationwhen the fake returns'0x'.Discovered during
Deep audit of issue #542 (Tier 1 integration tests) — verifying the cited Tier-1 doc references against the actual fake implementation.
Test plan
grep -n SigningCancelledException docs/testing.mdandBitboxNotConnectedException— confirmed only the one drifted line toucheddart analyze— markdown change, no Dart impact