docs(readme): reflect golden tests in the feature matrix#566
Merged
TaprootFreak merged 2 commits intoMay 23, 2026
Merged
Conversation
Every lib/screens/**/*_page.dart now has a companion test/goldens/**/*_golden_test.dart and a committed pixel baseline. The feature matrix needs to reflect that: - Tests legend: new 'golden' test type with a pointer to docs/visual-regression-tests.md - Every page row in the four feature sections gets its golden test path appended to the existing widget/cubit/unit entries - Two new rows (Settings root, Support root) for pages that exist in the app but weren't in the previous matrix - Three previously-empty rows flipped from '—' to 'golden (...)': Sell to BitBox, Currencies/Languages/Network, Tax report, Contact, KYC AccountMergeRequested - Triage gaps: new 'Visual regression (goldens)' bullet documenting the gate, web_view skip:true exception, and the cross-link - CI/CD table: pull-request.yaml row now mentions --exclude-tags golden on the existing test step plus the parallel Visual Regression job on the dfx01 runner
Pilot branch had the CI trigger phrasing updated to 'Any PR except PRs to main', this branch had the golden-tests additions. Both kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #541. README-only — no code, no baseline touched.
What changed
The repo's Feature Matrix (`README.md` Sections "Onboarding & authentication" / "Wallet actions" / "DFX backend integration" / "Settings" / "Support") didn't reflect the 57 golden tests added in #541. This PR closes that gap.
Verified
After merge
#541 stays as before; this PR can land before or after #541. If it lands first, GitHub auto-rebases #541 against the updated develop on next push.