test(goldens): cover Settings page BitBox-open variant#590
Merged
TaprootFreak merged 3 commits intoMay 26, 2026
Conversation
The Handbook claims the Wallet-Sicherung tile is hidden when a BitBox wallet is open (settings_page.dart:100 gates it on walletType == WalletType.software). The existing golden only covers the software-wallet branch — invert the condition by mistake and no test fails. Add a sibling goldenTest with a BitBox wallet so the hidden-tile contract is locked in by a baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/handbook/de/index.html:1088-1090) behauptet, die Wallet-Sicherung-Kachel ist bei BitBox-Wallet ausgeblendetsettings_page.dart:100würde nicht auffallengoldenTest„bitbox wallet open hides the Wallet-Sicherung tile" sichert die hidden-tile-Logik abMockBitboxWalletintest/helper/golden_mocks.dartergänzt (analog zuMockSoftwareWallet)Schließt Reviewer-Finding #2 aus dem #582-Review.
Test plan
golden-regenerate.yamlauf dfx01 generiert (erwartet: 1 neuer PNGsettings_page_bitbox.png)