fix(settings): hide Network-mode row from production builds#636
Closed
TaprootFreak wants to merge 1 commit into
Closed
fix(settings): hide Network-mode row from production builds#636TaprootFreak wants to merge 1 commit into
TaprootFreak wants to merge 1 commit into
Conversation
The Mainnet/Testnet toggle in Settings is a developer affordance — there is no end-user reason to switch networks and an accidental tap drops the user onto Testnet with broken liquidity and a forced reauth on every subsequent network round-trip. Wraps the SettingOption that opens `SettingsNetworkPage` in a `if (kDebugMode)` collection-if, mirroring the existing pattern in `lib/screens/welcome/welcome_page.dart:125` for the Address+Signature debug entry. `SettingsNetworkPage`, `SettingsRoutes.network`, `SettingsBloc` network-mode state, and `SettingsRepository.networkMode` all stay — debug builds still expose the toggle, the default Mainnet mode stays active for everyone, and an internal dev can flip via a debug build when needed.
Contributor
Author
|
Folded into #635 — consolidated handbook §02/§03/§12 update into one PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hides the Settings → Network row (Mainnet/Testnet toggle) from production builds.
The toggle is a developer affordance — an end-user has no legitimate reason to switch networks, and an accidental tap drops them onto Testnet with broken liquidity and a forced reauth on every subsequent network round-trip.
Change
Wraps the
SettingOptionthat opensSettingsNetworkPagein aif (kDebugMode)collection-if. This mirrors the existing pattern inlib/screens/welcome/welcome_page.dart:125, where the Address + Signature debug entry is hidden the same way.What stays:
SettingsNetworkPage,SettingsRoutes.network,SettingsBlocnetwork-mode state,SettingsRepository.networkMode— all untouched.Test plan
flutter analyzeclean on the touched file.settings_pagegolden will drift; regenerate viagolden-regenerate.yamlafter merge to refresh the handbook screenshot (§12-settings).