Promote: staging -> develop#640
Merged
Merged
Conversation
…dates (#635) ## Summary Applies three product updates to the wallet-type selection (handbook §02), the software-wallet-terms screen (handbook §03), and the Settings page (handbook §12). The Step 1 / Step 2 onboarding architecture and the Network mode itself stay; only the user-facing surface changes. ## §02 / §03 — wallet-type screen copy Five strings on the wallet-type selection (handbook §02) and the software-wallet-terms screen (handbook §03) are rewritten per the latest product handbook copy. The two-step architecture (Step 1 = Software-Wallet vs BitBox, Step 2 = Create vs Restore vs Debug) is unchanged. | ARB key | Old (DE / EN) | New (DE / EN) | |---|---|---| | `realunitWalletSubtitle` | Verwalten Sie Ihre RealUnit Token kostenfrei und bankenunabhängig. / Manage your RealUnit tokens free of charge and independently of banks. | Kaufen und verwalten Sie RealUnit Aktientoken kostenfrei und bankenunabhängig. / Buy and manage RealUnit stock tokens free of charge and independently of banks. | | `softwareWallet` | Digitale Wallet (App) / Software Wallet | Software-Wallet (App) / Software Wallet (App) | | `softwareWalletSubtitle` | Ich möchte eine neue Wallet für den Handel und die Aufbewahrung der RealUnit Token erstellen. / I would like to create a new wallet for trading and storing RealUnit tokens. | Ich möchte eine neue Wallet erstellen oder meine bestehende Wallet (z.B. Aktionariat) wiederherstellen. / I want to create a new wallet or restore my existing wallet (e.g. Aktionariat). | | `bitbox` | BitBox / BitBox | BitBox Hardware-Wallet / BitBox Hardware Wallet | | `hardwareWalletSubtitle` | Verwahren Sie Ihre RealUnit Aktientoken auf diesem separaten, physischen Gerät (einer "Hardware Wallet") aus der Schweiz. / Store your RealUnit stock tokens on this separate, physical device (a "hardware wallet") from Switzerland. | Ich besitze eine Bitbox02 Nova und möchte RealUnit Token darauf verwahren. / I own a Bitbox02 Nova and want to store RealUnit tokens on it. | Reuse confirmed: the `bitbox` key is only referenced in `lib/screens/welcome/welcome_page.dart:92` as the tile title — the BitBox-disconnected / reconnect strings use separate keys (`bitboxDisconnectedTitle`, `bitboxDisconnectedDescription`, `bitboxReconnect`). The rename does not bleed into other screens. `docs/handbook/de/index.html` §02 description rewritten to match the renamed tiles and the broader software-wallet scope. §03 prose is unchanged — the two-step architecture stays, and its screenshot picks up the new header subtitle automatically via the shared welcome-page golden. ## §12 — hide Network-mode row from production builds The Settings → Network row (Mainnet/Testnet toggle) is a developer affordance — an end-user has no legitimate reason to switch networks, and an accidental tap drops them onto Testnet with broken liquidity and a forced reauth on every subsequent network round-trip. The `SettingOption` that opens `SettingsNetworkPage` is wrapped in a `if (kDebugMode)` collection-if, mirroring the existing pattern in `lib/screens/welcome/welcome_page.dart:125` (the **Address + Signature** debug entry). `SettingsNetworkPage`, `SettingsRoutes.network`, `SettingsBloc` network-mode state, `SettingsRepository.networkMode` — all untouched. Default Mainnet stays active for everyone, debug builds still expose the toggle. ## Goldens Three golden surfaces drift on this PR: - `welcome/goldens/macos/welcome_page_ios.png` (handbook §02) - `welcome/goldens/macos/welcome_page_second_step.png` (handbook §03 — header subtitle pulls the new copy) - `settings/goldens/macos/settings_page_default.png` (handbook §12 — Network row gone) Visual Regression will fail on this PR until the goldens are regenerated on the dfx01 self-hosted runner via the `golden-regenerate.yaml` workflow. Once regenerated and pushed, Visual Regression turns green and the handbook screenshots refresh automatically (the mapping in `scripts/assemble-handbook-screenshots.sh` already points at these three files). ## Out of scope - §01 (welcome splash claim `Bankenunabhängig. Sicher.` → `Sicher. Einfach. Bankenunabhängig.`) — the claim is baked into `assets/images/splash/splash_background.png`; needs a fresh asset from the designer before it can land. ## Test plan - [ ] `dart run tool/generate_localization.dart` regenerates `lib/generated/i18n.dart` with the new strings (already committed). - [ ] `flutter analyze` clean on the touched files. - [ ] Visual Regression: after golden regeneration, `welcome_page_ios.png`, `welcome_page_second_step.png`, and `settings_page_default.png` show the new copy / layout and the handbook screenshots pick them up. - [ ] Production build of the Settings page no longer lists the Network row; debug build still does. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Staging PR
This PR was automatically created after changes were pushed to staging.
Commits: 1 new commit(s)
Checklist