fix(buy): relabel payment button to its actual action (request payment instructions)#661
Merged
Merged
Conversation
The buy-payment button label told customers to transfer the money first and
click afterwards, but the click is in fact what requests the payment
instructions (PUT /v1/realunit/buy/{id}/confirm → requestPaymentInstructions
on the API side): the customer should click first, receive the payment slip by
email, then pay. Update only the buyPaymentConfirm label in both ARB files so
it matches what the button actually does. No behaviour, flow or API change.
Tester feedback: Bojan Jankovic, 28.05.2026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #660.
Pure i18n label fix. The buy-payment button told customers to transfer the money first and click afterwards, but the click is exactly what requests the payment instructions (
PUT /v1/realunit/buy/{id}/confirm→requestPaymentInstructionson the API side, setsWAITING_FOR_PAYMENT, returns a reference). The customer should click first, receive the payment slip by email, then pay. Tester feedback: Bojan Jankovic, 28.05.2026 — "Einzig den Text auf dem Button sollte man ändern."Change (label only)
Klicken Sie hier, sobald Sie die Überweisung getätigt habenZahlungsanweisungen per E-Mail anfordernClick here once you have made the transferRequest payment instructions by emailOnly the
buyPaymentConfirmvalue inassets/languages/strings_de.arb+strings_en.arb(key keeps its alphabetical position).lib/generated/i18n.dartis git-ignored and regenerated in CI (dart run tool/generate_localization.dart).Strictly out of scope (untouched)
confirmPayment/BuyConfirmCubitlogic, the/confirmendpoint and any API behaviour,buyPaymentInformationDescription,buyExecutedDescription/PaymentExecutedSheet, and the error stringsbuyPaymentConfirmFailed/buyPaymentConfirmFailedAktionariat.Tests & goldens
buyPaymentConfirmkey (verified across all oftest/) — no test code change needed. The button consumer (payment_information_details.dart) uses the generated getter, so the new label takes effect andonPressedstill callsconfirmPayment.buy_payment_info_loadedgolden renders this button and changes;golden-regenerate.yamlwas triggered on this branch immediately after push (not waiting for Visual Regression to fail). The other 6 buy goldens don't render this button and are unaffected.3-subagent review: Quality + Logic both PASS_CLEAN. Draft until CI (incl. regenerated golden) is green.