fix(splash): regenerate native launch assets (OS launch splash showed old image)#670
Merged
Merged
Conversation
#667 only replaced the Flutter source asset (splash_background.png) but did not re-run flutter_native_splash:create, so the OS launch splash (iOS LaunchImage.imageset + Android res/drawable-*/splash.png) still showed the old image. Regenerated those native assets from the new background so the launch splash matches the in-app Welcome background.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #667 replaced
assets/images/splash/splash_background.png, the OS launch splash (the full-screen image shown for ~1–3 s on app start, before Flutter loads) still showed the old image — even though the in-app Welcome/HomePage background (which uses the Flutter asset directly) was correct.Cause
The iOS launch splash is not loaded from
splash_background.pngdirectly. The project usesflutter_native_splash, which generates native launch assets (ios/Runner/Assets.xcassets/LaunchImage.imageset/*,android/app/src/main/res/drawable-*/splash.png). #667 swapped the source image but did not re-runflutter_native_splash:create, so those generated assets were stale.Fix
Ran
dart run flutter_native_splash:create -p pubspec.yaml→ regenerated the native iOS + Android launch assets from the new background. Verified the newLaunchImage.pngshows the updated subline ("Sicher. Einfach. Bankenunabhängig."). No code/config change;Info.plist/styles.xml/launch_background.xmlunchanged;pubspec.lockintentionally not touched.Note
The OS launch splash only updates in a new build (next v1.0.x). The in-app Welcome background was already correct from v1.0.83 onward.