fix(wallet-address): display receive address in EIP-55 checksummed form#696
Merged
Merged
Conversation
…d form The wallet address screen rendered AppStore.primaryAddress, which is the lowercase `.hex` form, in both the QR code and the address text. Show the EIP-55 checksummed form instead — the canonical representation that lets the user verify the address by its checksum. Scoped to this screen; AppStore and other consumers are unchanged.
The regenerate run also rewrote home_page_loaded.png with a sub-pixel diff unrelated to this change. Revert it to the staging baseline so this PR touches only the wallet-address golden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Wallet-Adresse screen rendered the receive address in lowercase (
0x127d4a7e…ae8aa2) in both the QR code and the address text.SettingsWalletAddressPageusedAppStore.primaryAddress, which returns the lowercase.hexform.The canonical, verifiable representation of an Ethereum address is its EIP-55 checksummed form (mixed case). Showing lowercase is incorrect for a receive address users are meant to verify.
Fix
settings_wallet_address_page.dart, convert the address to its checksummed form viaEthereumAddress.fromHex(...).hexEip55before passing it to the QR code and the displayed text.AppStore.primaryAddressand all other consumers are untouched (per request: wallet-address screen fix only).Tests
QRAddressWidgetreceives the checksummed address in both itssubtitle(text) anduri(QR), given a lowercase mock.flutter analyzeclean; page + QR-widget tests green.settings_wallet_address_page_defaultregenerated viagolden-regenerate.yaml(address text now mixed-case).Test plan