Fix read from unknown address in Image::get_pixel#12
Merged
madmiraal merged 1 commit intoJul 4, 2023
Conversation
Perform validity checks for external calls to get_pixel and set_pixel. Don't perform validity checks for interal calls to get_pixel and set_pixel.
madmiraal
added
PR Type: Bug Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently calls to
Image::get_pixel()andImage::set_pixel()only perform validity checks when debug is enabled. The checks performed are:Imagebeen locked?xandyparameters within the image dimensions?This is presumably done for performance reasons, but it can result in reads and writes from and to invalid memory addresses when running a released game.
This PR separates internal and external calls to
Image::get_pixel()andImage::set_pixel(). Validity checks are always performed when external calls are made toImage::get_pixel()andImage::set_pixel(). Validity checks are not performed when internal calls are made toImage::get_pixel()andImage::set_pixel(). Validity checks are not desired on internal calls, because they are made during nested loop calls, and validity checks are not required on internal calls, because validity checks will have already been performed outside of the nested loops.