Add a default copy constructor to CharProxy#154
Merged
DanielaOrtner merged 1 commit intoApr 12, 2025
Conversation
madmiraal
added
the
PR Type: Bug Fix
DanielaOrtner
approved these changes
Apr 12, 2025
Contributor
DanielaOrtner
left a comment
DanielaOrtner
left a comment
There was a problem hiding this comment.
Thank you for keeping our code clear and precise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is copy assignment operator defined, relying on the definition of an implicit copy constructor is deprecated. Currently
CharProxy<T>has a copy assignment operator defined, but no copy constructor:RebelEngine/core/ustring.h
Lines 45 to 47 in d310162
This PR tells the compiler to use the default copy constructor.