Ensure that GLES Canvas batch pointer is never a nullptr#167
Merged
DanielaOrtner merged 1 commit intoMay 5, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when requesting a new GLES Canvas Batch, a
nullptrwill be returned if the array is full. When anullptris returned, the Batch arrays are grown, and a new Batch is requested:RebelEngine/drivers/gles_common/rasterizer_canvas_batcher.h
Lines 825 to 837 in 0ded452
Since, after the array is grown, it can never be full, we can be certain that, when now requesting a new GLES Canvas Batch, a
nullptrwill never be returned. However, the compiler cannot be certain of this, and it complains that, if anullptris returned, we cannot usememseton it:Instead of trying to fix the code to ensure a
nullptris never returned, which would require considerable refactoring, and instead of telling the compiler we will crash Rebel Engine if anullptris returned after growing the array (which currently only happens in Rebel Editor and only in debug builds) this PR uses awhileloop to convince the compiler that the pointer to the new Batch will never be anullptr.