Skip to content

Refactor ProjectSettings#172

Merged
DanielaOrtner merged 1 commit into
RebelToolbox:mainfrom
madmiraal:refactor-project-settings
Jun 9, 2025
Merged

Refactor ProjectSettings#172
DanielaOrtner merged 1 commit into
RebelToolbox:mainfrom
madmiraal:refactor-project-settings

Conversation

@madmiraal
Copy link
Copy Markdown
Contributor

To clean and simplify the code and make it easier to read and maintain in the future, this PR refactors the ProjectSettings class.

  • Restructures files to make the public interface clearer
  • Initialises variables in the header
  • Renames variables, private methods, typedefs, etc. to better reflect their purpose
  • Simplifies and merges internal structs
  • Removes unused methods and variables
  • Makes const methods const.
  • Simplifies methods to make them easier to understand
  • Makes error messages clearer and comments relevant

@madmiraal madmiraal added the PR Type: Enhancement Your current game will work better. label Jun 9, 2025
@madmiraal madmiraal force-pushed the refactor-project-settings branch from 72af3e6 to 4cab77f Compare June 9, 2025 16:53
@DanielaOrtner DanielaOrtner self-requested a review June 9, 2025 18:35
@DanielaOrtner DanielaOrtner merged commit 4e2bfdf into RebelToolbox:main Jun 9, 2025
15 checks passed
@madmiraal madmiraal deleted the refactor-project-settings branch June 10, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR Type: Enhancement Your current game will work better.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants