Defer Projects Manager's Projects List's call to ensure_control_visible()#181
Merged
DanielaOrtner merged 1 commit intoJul 17, 2025
Conversation
DanielaOrtner
approved these changes
Jul 17, 2025
madmiraal
added
PR Type: Bug Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when renaming a project in Projects Manager, the position of the project in the list is updated, but, despite a call being made to
ScrollContainer'sensure_control_visible()the view is not updated to ensure the item remains visible.This PR defers the call to
ScrollContainer'sensure_control_visible()to ensure that the changes to the control's new position are available before calculating how much to scroll theScrollContainer.