Simplify ProjectsList#183
Merged
DanielaOrtner merged 2 commits intoJul 18, 2025
Merged
Conversation
DanielaOrtner
approved these changes
Jul 18, 2025
Contributor
DanielaOrtner
left a comment
DanielaOrtner
left a comment
There was a problem hiding this comment.
Thanks for making our code base simpler to maintain and understand :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Project Manger's
ProjectsListuses aSetto store the project keys of currently selected projects, and, when needed, converts thisSetto aVectorofProjectsListItempointers. In addition, the first selected item is stored as index number to the list of projects, and, also when needed, converts this index to theProjectsListItem.To simplify things, this PR converts the
Setof project keys to aVectorofProjectListItempointers and converts the reference to the first selected item to a pointer to the list item itself. This alleviates the need to make the conversion every time it is needed.