Make the Android default build arm64v8#39
Merged
Conversation
DanielaOrtner
approved these changes
Feb 22, 2024
Contributor
DanielaOrtner
left a comment
There was a problem hiding this comment.
Thank you for updating Rebel to stick with current standards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default build architecture for all platforms is 64 bit; except for the Android platform. Since all new devices are 64 bit and 32 bit is only kept for backwards compatibility, it makes sense for the default to be 64 bit and it to be consistent across platforms.
Android also supports both Arm and Intel chipsets. On Android devices, except for very few devices, and the emulators, most devices use the Arm chipset. Therefore, this change makes the default Android build be for the 64 bit Arm chipset.
Note: This only changes the default build, all other architectures can still be built by specifying the required architecture.