Skip to content

Fix Android Rebel rebranding#43

Merged
DanielaOrtner merged 5 commits into
RebelToolbox:mainfrom
madmiraal:fix-android-rebrand
Mar 7, 2024
Merged

Fix Android Rebel rebranding#43
DanielaOrtner merged 5 commits into
RebelToolbox:mainfrom
madmiraal:fix-android-rebrand

Conversation

@madmiraal
Copy link
Copy Markdown
Contributor

In addition to #42, there are a few other inconsistencies following #16:

  • Android custom build doesn't use RebelInstrumentation
  • A Variant containing a Rebel Dictionary is not working on Android
  • The Android Studio build of Rebel hasn't been updated to use Rebel branding
  • Android logging hasn't hasn't been updated to use Rebel branding
  • The Android custom build template version mismatch message hasn't been updated to use Rebel branding

This PR addresses these issues.

@DanielaOrtner DanielaOrtner self-requested a review March 7, 2024 16:22
Copy link
Copy Markdown
Contributor

@DanielaOrtner DanielaOrtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing the Android side of things along.
:)

@DanielaOrtner DanielaOrtner merged commit dac68dc into RebelToolbox:main Mar 7, 2024
@madmiraal madmiraal deleted the fix-android-rebrand branch March 8, 2024 11:06
@madmiraal madmiraal added PR Type: Bug Fix Your current game should now work as expected. PR Type: Enhancement Your current game will work better. and removed bug labels May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR Type: Bug Fix Your current game should now work as expected. PR Type: Enhancement Your current game will work better.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants