Ensure Android Java and Kotlin compile to the same version#46
Merged
DanielaOrtner merged 1 commit intoMar 16, 2024
Merged
Conversation
DanielaOrtner
approved these changes
Mar 16, 2024
Contributor
DanielaOrtner
left a comment
DanielaOrtner
left a comment
There was a problem hiding this comment.
Fantastic work! Well spotted.
Thanks for keeping it all the same.
madmiraal
added
PR Type: Bug Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebel version of godotengine/godot#61580 (and godotengine/godot#61579).
Currently there is a mismatch between the Java and Kotlin classes compilation version targets. Java classes are being compiled using Java version 11, but the Kotlin classes are being compiled to be compatible with Java version 1.8.
This PR ensures that Java and Kotlin classes are compiled to the same Java version: 11.