Replace distutils.dir_util.copy_tree with shutil.copytree#47
Merged
DanielaOrtner merged 1 commit intoMar 25, 2024
Merged
Conversation
DanielaOrtner
approved these changes
Mar 25, 2024
Contributor
DanielaOrtner
left a comment
DanielaOrtner
left a comment
There was a problem hiding this comment.
Great work to bring us up to date :)
madmiraal
added
PR Type: Bug Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python has, for a long time, recommended using
setuptoolsinstead ofdistutils[1]. In Python 3.10,distutilswas deprecated [2]. In Python 3.12, it was removed [3]. However, the Mono module is still usingdistutils.This PR uses
setuptools'shutilinstead ofdistutils. Specifically, it replacesdistutils.dir_util.copy_treewithshutil.copytree.[1] https://docs.python.org/3.9/library/distutils.html
[2] https://peps.python.org/pep-0632/
[3] https://docs.python.org/3/whatsnew/3.12.html